Skip to content

backup-top filter driver for backup

Vladimir Sementsov-Ogievskiy qemu-devel 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest14 patches 7 repliesIn review
  2. v1014 patches 18 repliesSuperseded
  3. v913 patches 25 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v87 patches22 repliesSuperseded
v75 patches3 repliesSuperseded
v65 patches5 repliesSuperseded
v511 patches39 repliesSuperseded
v411 patches8 repliesSuperseded

Patches in v11 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14block/backup: fix backup_cow_with_offload for last clusterblock/backup.c+1 -10 replies
2/14block/backup: split shareable copying part from backup_do_cowblock/backup.c+32 -150 replies
3/14block/backup: improve comment about image fleecingblock/backup.c+12 -30 replies
4/14block/backup: introduce BlockCopyStateblock/backup.c block/trace-events+231 -1376 replies
5/14block/backup: fix block-comment styleblock/backup.c+21 -110 replies
6/14block: move block_copy from block/backup.c to separate fileblock/Makefile.objs block/backup.c block/block-copy.c +2 more+404 -3450 replies
7/14block: teach bdrv_debug_breakpoint skip filters with backingblock.c+26 -80 replies
8/14iotests: prepare 124 and 257 bitmap querying for backup-top filtertests/qemu-iotests/124 tests/qemu-iotests/257 tests/qemu-iotests/257.out +1 more+219 -3040 replies
9/14iotests: 257: drop unused Drive.device fieldtests/qemu-iotests/257+15 -220 replies
10/14iotests: 257: drop device_addtests/qemu-iotests/257 tests/qemu-iotests/257.out+0 -520 replies
11/14block/io: refactor wait_serialising_requestsblock/io.c+16 -80 replies
12/14block: add lock/unlock range functionsblock/io.c include/block/block_int.h+47 -10 replies
13/14block: introduce backup-top filter driverblock/Makefile.objs block/backup-top.c block/backup-top.h+283 -00 replies
14/14block/backup: use backup-top instead of write notifiersblock/backup-top.c block/backup.c block/block-copy.c +8 more+237 -2770 replies

Reviews trailers per patch

13 of 14 patches have a Reviewed-by or Acked-by.

PatchMax Reitz
1/14R-b
2/14R-b
3/14R-b
4/14
5/14R-b
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [Qemu-devel] [PATCH v11 00/14] backup-top filter driver for backup

Hi all!

These series introduce backup-top driver. It's a filter-node, which do copy-before-write operation. Mirror uses filter-node for handling guest writes, let's move to filter-node (from write-notifiers) for backup too.

v11: based on Kevin's block branch

02,03: Add Max's r-b
04: - improve comments
- rebase on dropped backup_drain
- s/job/bcs/ in trace events
05: one hunk dropped due to rebasing
on dropped backup_drain, still,
keep Max's r-b
06: rebased on 04 changes, keep Max's r-b
08,13,14: add Max's r-b

Based-on: git://repo.or.cz/qemu/kevin.git block

Vladimir Sementsov-Ogievskiy (14):
block/backup: fix backup_cow_with_offload for last cluster block/backup: split shareable copying part from backup_do_cow block/backup: improve comment about image fleecing block/backup: introduce BlockCopyState
block/backup: fix block-comment style
block: move block_copy from block/backup.c to separate file
block: teach bdrv_debug_breakpoint skip filters with backing
iotests: prepare 124 and 257 bitmap querying for backup-top filter
iotests: 257: drop unused Drive.device field
iotests: 257: drop device_add
block/io: refactor wait_serialising_requests
block: add lock/unlock range functions
block: introduce backup-top filter driver
block/backup: use backup-top instead of write notifiers

 qapi/block-core.json          |   8 +-
 block/backup-top.h            |  37 ++
 include/block/block-copy.h    |  84 ++++
 include/block/block_int.h     |   5 +
 block.c                       |  34 +-
 block/backup-top.c            | 240 ++++++++++++
 block/backup.c                | 440 ++++-----------------
 block/block-copy.c            | 337 ++++++++++++++++
 block/io.c                    |  68 +++-
 block/replication.c           |   2 +-
 blockdev.c                    |   1 +
 block/Makefile.objs           |   3 +
 block/trace-events            |  14 +-
 tests/qemu-iotests/056        |   8 +-
 tests/qemu-iotests/124        |  83 ++--
 tests/qemu-iotests/257        |  91 ++---
 tests/qemu-iotests/257.out    | 714 ++++++++++++++--------------------
 tests/qemu-iotests/iotests.py |  27 ++
 18 files changed, 1278 insertions(+), 918 deletions(-)
 create mode 100644 block/backup-top.h
 create mode 100644 include/block/block-copy.h
 create mode 100644 block/backup-top.c
 create mode 100644 block/block-copy.c
Signature · 1 line
2.18.0