Skip to content

Refactor compression initialization

Kees Cook lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 8 repliesIn review
  2. v11 patch 6 repliesSuperseded

Changes in v2 from the cover letter

- add init refactoring to avoid modular build failures.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pstore: Centralize init/exit routinesfs/pstore/inode.c fs/pstore/internal.h fs/pstore/platform.c+28 -110 replies
2/4pstore: Allocate compression during late_initcall()fs/pstore/platform.c fs/pstore/ram.c+10 -26 replies
3/4pstore: Refactor compression initializationfs/pstore/platform.c+33 -150 replies
4/4pstore/ram: Clarify resource reservation labelsfs/pstore/ram.c fs/pstore/ram_core.c include/linux/pstore_ram.h+22 -80 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchSai Prakash RanjanJoel Fernandes (Google)Guenter Roeck
SeriesT-b
1/4
2/4T-b
3/4
4/4T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH pstore-next v2 0/4] Refactor compression initialization

Sai noticed pstore wasn't catching early crashes, so Joel fixed it by moving init earlier again (with compression init done later). I refactored things a bit to avoid modular build problems noticed by Guenter. And while doing this work, I also improved /proc/iomem labels after Dan helped me get NVDIMM working so I could meaningfully test the very early crash handling.

Thanks everyone!

-Kees

v2:
- add init refactoring to avoid modular build failures.

Joel Fernandes (Google) (1):
pstore: Allocate compression during late_initcall()

Kees Cook (3):
pstore: Centralize init/exit routines
pstore: Refactor compression initialization
pstore/ram: Clarify resource reservation labels

 fs/pstore/inode.c          | 11 +-----
 fs/pstore/internal.h       |  5 ++-
 fs/pstore/platform.c       | 75 +++++++++++++++++++++++++++++++-------
 fs/pstore/ram.c            | 18 +++++++--
 fs/pstore/ram_core.c       | 11 ++++--
 include/linux/pstore_ram.h |  3 +-
 6 files changed, 90 insertions(+), 33 deletions(-)
Signature · 1 line
2.17.1