Skip to content

hw/misc: Add a MMIO interface to the pvpanic device

Philippe Mathieu-Daudé qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 8 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4hw/misc/pvpanic: Build the pvpanic device in $(common-obj)hw/misc/Makefile.objs+1 -10 replies
2/4hw/misc/pvpanic: Cosmetic renaminghw/misc/pvpanic.c+9 -70 replies
3/4hw/misc/pvpanic: Add the MMIO interfacehw/misc/pvpanic.c+51 -14 replies
4/4hw/arm/virt: Use the pvpanic devicedefault-configs/arm-softmmu.mak hw/arm/virt.c include/hw/arm/virt.h+23 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/4] hw/misc: Add a MMIO interface to the pvpanic device

Hi, this series takes Peng Hao's previous work but rather than adding yet another device, simply add the MMIO interface to the current device (which only implements the I/O port access).

The first patches are simple cleanups:
- patch 1 move the pvpanic device with the 'ocmmon objects' so we compile it once for the x86/arm/aarch64 archs,
- patch 2 simply renames ISA fields/definitions to generic ones.

Then instead of add/use the MMIO pvpanic device in the virt machine in an unique patch, I split it in two distinct patches:
- patch 3 uses Peng Hao's work, but add the MMIO interface to the existing device (no logical change).
- patch 4 is Peng Hao's work in the virt machine (no logical change).

v2 from Peng Hao is:
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg03433.html

Regards,

Phil.

Philippe Mathieu-Daudé (4):
hw/misc/pvpanic: Build the pvpanic device in $(common-obj) hw/misc/pvpanic: Cosmetic renaming hw/misc/pvpanic: Add the MMIO interface hw/arm/virt: Use the pvpanic device

 default-configs/arm-softmmu.mak |  2 +-
 hw/arm/virt.c                   | 21 ++++++++++
 hw/misc/Makefile.objs           |  2 +-
 hw/misc/pvpanic.c               | 68 +++++++++++++++++++++++++++++----
 include/hw/arm/virt.h           |  1 +
 5 files changed, 84 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.2