Skip to content

Overlay inode lock cleanups

Amir Goldstein linux-unionfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ovl: remove the 'locked' argument of ovl_nlink_{start,end}fs/overlayfs/dir.c fs/overlayfs/overlayfs.h fs/overlayfs/util.c+25 -280 replies
2/2ovl: abstract ovl_inode lock with a helperfs/overlayfs/overlayfs.h fs/overlayfs/util.c+23 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Overlay inode lock cleanups

Miklos,

First patch removes pretty big ugliness. Second patch is just a matter of taste, so as you wish.

I'll use this opportunity to recap the queue of my proposed patches for v4.20, so you can see if you missed to consider any of them:

* 5401b99fcbb9 - (overlayfs-devel) ovl: abstract ovl_inode lock with a helper
* 8edcbcef4e55 - ovl: remove the 'locked' argument of ovl_nlink_{start,end}
* bd2ea818ecca - ovl: relax requirement for non null uuid of lower fs
* 19c221c3a6b5 - ovl: disable new features for deprecated upper fs
* 1c785e83823c - ovl: untangle copy up call chain
* b67871490628 - (ovl-fixes) ovl: fix recursive oi->lock in ovl_link()
* e39a0eb89ae4 - vfs: fix FIGETBSZ ioctl on an overlayfs file
* 431d5170b91d - ovl: fix error handling in ovl_verify_set_fh()
* 388b00daecb8 - kernel/acct.c: fix locking order when switching acct files

Thanks,
Amir.

Amir Goldstein (2):
ovl: remove the 'locked' argument of ovl_nlink_{start,end}
ovl: abstract ovl_inode lock with a helper

 fs/overlayfs/dir.c       | 21 ++++++++++----------
 fs/overlayfs/overlayfs.h | 14 +++++++++++--
 fs/overlayfs/util.c      | 43 +++++++++++++++++++---------------------
 3 files changed, 43 insertions(+), 35 deletions(-)
Signature · 1 line
2.17.1