Skip to content

vicodec: a couple fixes towards spec compliancy

Ezequiel Garcia linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v12 patches 9 repliesSuperseded

Changes in v2 from the cover letter

* Add more info to commit logs
* Propagate changes on both encoders and decoders
* Add pixel format helpers

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4media: Introduce helpers to fill pixel format structsdrivers/media/v4l2-core/Makefile drivers/media/v4l2-core/v4l2-common.c drivers/media/v4l2-core/v4l2-fourcc.c +2 more+218 -12 replies
2/4vicodec: Use pixel format helpersdrivers/media/platform/vicodec/codec-v4l2-fwht.c drivers/media/platform/vicodec/codec-v4l2-fwht.h drivers/media/platform/vicodec/vicodec-core.c+48 -920 replies
3/4vicodec: Propagate changes to the CAPTURE queuedrivers/media/platform/vicodec/vicodec-core.c+22 -00 replies
4/4vicodec: Implement spec-compliant stop commanddrivers/media/platform/vicodec/vicodec-core.c+44 -360 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] vicodec: a couple fixes towards spec compliancy

Given the stateful codec specification is still a moving target, it doesn't make any sense to try to comply fully with it.

On the other side, we can still comply with some basic userspace expectations, with just a couple small changes.

This series implements proper resolution changes propagation, and fixes the CMD_STOP so it actually works.

The intention of this series is to be able to test this driver using already existing userspace, gstreamer in particular. With this changes, it's possible to construct variations of this pipeline:

gst-launch-1.0 videotestsrc ! v4l2fwhtenc ! v4l2fwhtdec ! fakevideosink

Also, as discussed in v1 feedback [1,2], I'm including pixel format helpers, as RFC for now. Hans, Tomasz: is this what you had in mind?

[1] https://www.spinics.net/lists/linux-media/msg141912.html
[2] https://www.spinics.net/lists/linux-media/msg142099.html

v2:
* Add more info to commit logs
* Propagate changes on both encoders and decoders
* Add pixel format helpers

Ezequiel Garcia (4):
media: Introduce helpers to fill pixel format structs
vicodec: Use pixel format helpers
vicodec: Propagate changes to the CAPTURE queue
vicodec: Implement spec-compliant stop command

 .../media/platform/vicodec/codec-v4l2-fwht.c  |  42 ++--
 .../media/platform/vicodec/codec-v4l2-fwht.h  |   3 -
 drivers/media/platform/vicodec/vicodec-core.c | 197 +++++++++---------
 drivers/media/v4l2-core/Makefile              |   2 +-
 drivers/media/v4l2-core/v4l2-common.c         |  66 ++++++
 drivers/media/v4l2-core/v4l2-fourcc.c         |  93 +++++++++
 include/media/v4l2-common.h                   |   5 +
 include/media/v4l2-fourcc.h                   |  53 +++++
 8 files changed, 332 insertions(+), 129 deletions(-)
 create mode 100644 drivers/media/v4l2-core/v4l2-fourcc.c
 create mode 100644 include/media/v4l2-fourcc.h
Signature · 1 line
2.19.1