struct argv overhaul - round 2+x

Hi,

Since the hackathon a couple of weeks ago, I've picked up the work from Heiko Hund which does a big overhaul on the struct argv patches [0].

This patchset is rebased on the latest master and with my review comments embedded into Heikos patch. This was only relevant for the big 're-implement argv_printf_*()' patch.

In addition, I've added a separate documentation patch which adds doxygen comments to basically all functions in argv.c, trying to explain better what each of these functions does. To make the comment flow better, I renamed a few variables and did minor refactoring changes on the coding style.

--
kind regards,

David Sommerseth
OpenVPN Inc

David Sommerseth (1):
Documented all the argv related code with minor refactoring

Heiko Hund (3):
re-implement argv_printf_*()
argv: do fewer memory re-allocations
Add gc_arena to struct argv to save allocations

 src/openvpn/argv.c                   | 525 +++++++++++++++++----------
 src/openvpn/argv.h                   |   7 +-
 src/openvpn/console_systemd.c        |   2 +-
 src/openvpn/init.c                   |  15 +-
 src/openvpn/lladdr.c                 |   2 +-
 src/openvpn/multi.c                  |  10 +-
 src/openvpn/options.c                |   2 +-
 src/openvpn/plugin.c                 |   2 +-
 src/openvpn/route.c                  |  16 +-
 src/openvpn/socket.c                 |   4 +-
 src/openvpn/ssl_verify.c             |   6 +-
 src/openvpn/tun.c                    |  62 ++--
 tests/unit_tests/openvpn/test_argv.c | 118 +++++-
 13 files changed, 496 insertions(+), 275 deletions(-)

2.17.1