Skip to content

delta-islands: avoid unused function messages

Carlo Marcelo Arenas Belón git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 5 repliesIn review
  2. v22 patches 2 repliesSuperseded

Changes in v3 from the cover letter

* Relay in the C code including git-compat-util as suggested by Jeff
* Commit message cleanup
* Make changes hdr-check clean

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3commit-slab: move MAYBE_UNUSED into git-compat-utilcommit-slab-impl.h git-compat-util.h+3 -30 replies
2/3khash: silence -Wunused-function in delta-islands from khashkhash.h+1 -11 reply
3/3commit-slab: missing definitions and forward declarations (hdr-check)commit-slab-impl.h commit-slab.h+4 -04 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] delta-islands: avoid unused function messages

the macro generated code from delta-islands (using khash) triggers some unused function warnings in macOS, OpenBSD and some linux with a newer version of clang because of its use of static functions.

Changes from v2:
* Relay in the C code including git-compat-util as suggested by Jeff
* Commit message cleanup
* Make changes hdr-check clean

Changes from v1:
* Use MAYBE_UNUSED for all cases as suggested by Duy

Carlo Marcelo Arenas Belón (3):
commit-slab: move MAYBE_UNUSED into git-compat-util
khash: silence -Wunused-function in delta-islands from khash
commit-slab: missing definitions and forward declarations (hdr-check)

 commit-slab-impl.h | 4 ++--
 commit-slab.h      | 2 ++
 git-compat-util.h  | 2 ++
 khash.h            | 2 +-
 4 files changed, 7 insertions(+), 3 deletions(-)
Signature · 1 line
2.19.1