Skip to content

multipathd: make uxlsnr errors really fatal

Martin Wilck dm-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 2 repliesIn review
  2. v27 patches 1 replySuperseded
  3. v17 patches 8 repliesSuperseded

Changes in v3 from the cover letter

04/07: Fixed cleanup code path (Ben).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7libmultipath: set pp->checkint in store_pathinfo()libmultipath/discovery.c multipathd/cli_handlers.c multipathd/main.c+1 -30 replies
2/7multipathd: remove init_path_check_interval()multipathd/main.c+0 -140 replies
3/7multipathd: print error message if checkint is not initializedlibmultipath/defaults.h libmultipath/dict.c libmultipath/structs.c +1 more+20 -20 replies
4/7multipathd: open client socket earlymultipathd/main.c multipathd/uxlsnr.c multipathd/uxlsnr.h+27 -191 reply
5/7multipathd: set DAEMON_CONFIGURE from uxlsnr threadmultipathd/main.c+32 -110 replies
6/7multipathd: make DAEMON_SHUTDOWN a terminal statemultipathd/cli_handlers.c multipathd/main.c+14 -50 replies
7/7multipathd: only grab conf once for filter_path()multipathd/main.c+4 -30 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchBenjamin Marzinski
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] multipathd: make uxlsnr errors really fatal

Hi Christophe,

this series, based on top of the recently submitted "various multipath-tools patches (v2)" and "checkers overhaul (v3)" series, fixes a problem that I recently observed: despite ee01e841 "multipathd: handle errors in uxlsnr as fatal", multipathd sometimes doesn't quit when the socket setup fails.

While at that, I stumbled upon init_path_check_interval(), wondered about its purpose, and came to the conclusion that can be quite easily obsoleted.

----
Changes v2->v3:
04/07: Fixed cleanup code path (Ben).

Changes v1->v2:
04/07: Fixed problem observed by Ben.

Martin Wilck (7):
libmultipath: set pp->checkint in store_pathinfo()
multipathd: remove init_path_check_interval()
multipathd: print error message if checkint is not initialized
multipathd: open client socket early
multipathd: set DAEMON_CONFIGURE from uxlsnr thread
multipathd: make DAEMON_SHUTDOWN a terminal state
multipathd: only grab conf once for filter_path()

 libmultipath/defaults.h   |   1 +
 libmultipath/dict.c       |  14 ++++-
 libmultipath/discovery.c  |   1 +
 libmultipath/structs.c    |   1 +
 multipathd/cli_handlers.c |  10 ++--
 multipathd/main.c         | 109 +++++++++++++++++++++++++-------------
 multipathd/uxlsnr.c       |  14 +----
 multipathd/uxlsnr.h       |   5 +-
 8 files changed, 98 insertions(+), 57 deletions(-)
Signature · 1 line
2.19.1

Read the cover letter in its thread