Skip to content

Adds -Wshadow on KBUILD_HOSTCFLAGS and fix warnings

Leonardo Bras linux-kbuild lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest5 patches 6 repliesIn review

Changes in v3 from the cover letter

- Better Cover letter
- Better commit message for patch 1/5.
- Fixes what should change on patch 3/5
- Removes accent of my second name (better for searching at lkml.org)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5x86/vdso: Renames variable to fix shadow warning.arch/x86/entry/vdso/vdso2c.h+7 -61 reply
2/5kbuild: Removes unnecessary shadowed local variable.scripts/asn1_compiler.c+1 -12 replies
3/5Creates macro to avoid variable shadowingscripts/mod/file2alias.c+15 -40 replies
4/5modpost: Changes parameter name to avoid shadowing.scripts/mod/modpost.c+2 -23 replies
5/5Adds -Wshadow on KBUILD_HOSTCFLAGSMakefile+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] Adds -Wshadow on KBUILD_HOSTCFLAGS and fix warnings

This patchset add -Wshadow on KBUILD_HOSTCFLAGS and fixes all code that show this warning.

Changes in v3:
- Better Cover letter
- Better commit message for patch 1/5.
- Fixes what should change on patch 3/5
- Removes accent of my second name (better for searching at lkml.org)

v2: https://lkml.org/lkml/2018/10/23/151
v1: https://lkml.org/lkml/2018/10/17/169

Leonardo Bras (5):
x86/vdso: Renames variable to fix shadow warning.
kbuild: Removes unnecessary shadowed local variable. Creates macro to avoid variable shadowing
modpost: Changes parameter name to avoid shadowing. Adds -Wshadow on KBUILD_HOSTCFLAGS

 Makefile                     |  2 +-
 arch/x86/entry/vdso/vdso2c.h | 13 +++++++------
 scripts/asn1_compiler.c      |  2 +-
 scripts/mod/file2alias.c     | 19 +++++++++++++++----
 scripts/mod/modpost.c        |  4 ++--
 5 files changed, 26 insertions(+), 14 deletions(-)
Signature · 1 line
2.19.1