Skip to content

app/testpmd: improve attach/detach support

Thomas Monjalon dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 3 repliesIn review
  2. v15 patches 10 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5app/testpmd: check not detaching device twiceapp/test-pmd/cmdline.c app/test-pmd/testpmd.c app/test-pmd/testpmd.h+30 -90 replies
2/5app/testpmd: merge ports list update functionsapp/test-pmd/testpmd.c+22 -520 replies
3/5app/testpmd: check not configuring port twiceapp/test-pmd/testpmd.c+4 -10 replies
4/5app/testpmd: move ethdev events registrationapp/test-pmd/testpmd.c+42 -301 reply
5/5app/testpmd: setup attached ports on probe eventapp/test-pmd/cmdline.c app/test-pmd/testpmd.c app/test-pmd/testpmd.h +1 more+95 -41 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchBernard Iremonger
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] app/testpmd: improve attach/detach support

While working on EAL probe/remove and ethdev iterator/close, some scenarios appeared to not be managed by testpmd, especially because it was not designed for multi-ports devices:
- configure dependent port (detected via event)
- configuring twice (if already probed before)
- detaching twice

Changes in v2 - Bernard review:
- improve pretty names of printed events
- add syntax of the new command in the guide

Thomas Monjalon (5):
app/testpmd: check not detaching device twice app/testpmd: merge ports list update functions app/testpmd: check not configuring port twice app/testpmd: move ethdev events registration app/testpmd: setup attached ports on probe event

 app/test-pmd/cmdline.c                      |  59 +++++-
 app/test-pmd/testpmd.c                      | 213 +++++++++++---------
 app/test-pmd/testpmd.h                      |   6 +-
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  11 +
 4 files changed, 193 insertions(+), 96 deletions(-)
Signature · 1 line
2.19.0