Remove nested TPM operations
Status from this message: Applied to master and next.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v11 Latest16 patches 25 repliesApplied
- v1017 patches 15 repliesSuperseded
- v917 patches 19 repliesSuperseded
Earlier versions · 9
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v8 | 17 patches | 9 replies | Superseded | |
| v7 posting 2/2 | 0 of 17 patches | 1 reply | Superseded | |
| v7 posting 1/2 | 17 patches | 10 replies | Superseded | |
| v6 | 17 patches | 2 replies | Superseded | |
| v5 | 17 patches | 20 replies | Superseded | |
| v4 | 17 patches | 0 replies | Superseded | |
| v3 | 15 of 16 patches | 17 replies | Superseded | |
| v2 | 1 patch | 0 replies | Superseded | |
| v1 | 1 patch | 0 replies | Superseded |
Changes in v11 from the cover letter
* Drop the patch that tries to flush TPM space on system. Not a proper fallback + out of scope for this patch set.
Patches in v11 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameterdrivers/ drivers/ drivers/ +4 more | +64 | 0 replies | |
| 2/16 | tpm: fix invalid return value in pubek_show()drivers/ | +2 | 0 replies | |
| 3/16 | tpm: return 0 from pcrs_show() when tpm1_pcr_read() failsdrivers/ | +6 | 0 replies | |
| 4/16 | tpm: print tpm2_commit_space() error inside tpm2_commit_space()drivers/ drivers/ | +6 | 0 replies | |
| 5/16 | tpm: declare struct tpm_headerdrivers/ drivers/ drivers/ +4 more | +34 | 0 replies | |
| 6/16 | tpm: access command header through struct in tpm_try_transmit()drivers/ | +2 | 0 replies | |
| 7/16 | tpm: encapsulate tpm_dev_transmit()drivers/ | +18 | 0 replies | |
| 8/16 | tpm: clean up tpm_try_transmit() error handling flowdrivers/ drivers/ drivers/ | +45 | 1 reply | |
| 9/16 | tpm: move tpm_validate_commmand() to tpm2-space.cdrivers/ drivers/ drivers/ | +67 | 0 replies | |
| 10/16 | tpm: move TPM space code out of tpm_transmit()drivers/ drivers/ drivers/ | +34 | 0 replies | |
| 11/16 | tpm: remove @space from tpm_transmit()drivers/ drivers/ drivers/ +5 more | +43 | 0 replies | |
| 12/16 | tpm: use tpm_try_get_ops() in tpm-sysfs.c.drivers/ | +78 | 0 replies | |
| 13/16 | tpm: remove TPM_TRANSMIT_UNLOCKED flagdrivers/ drivers/ drivers/ +3 more | +17 | 0 replies | |
| 14/16 | tpm: introduce tpm_chip_start() and tpm_chip_stop()drivers/ drivers/ drivers/ | +115 | 0 replies | |
| 15/16 | tpm: take TPM chip power gating out of tpm_transmit()drivers/ drivers/ drivers/ +2 more | +17 | 2 replies | |
| 16/16 | tpm: remove @flags from tpm_transmit()drivers/ drivers/ drivers/ +6 more | +65 | 0 replies |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by.
| Patch | Stefan Berger | Jerry Snitselaar | James Bottomley |
|---|---|---|---|
| 1/16 | R-b T-b | R-b | R-b |
| 2/16 | R-b T-b | R-b | R-b |
| 3/16 | R-b T-b | R-b | R-b |
| 4/16 | R-b T-b | R-b | R-b |
| 5/16 | R-b T-b | R-b | R-b |
| 6/16 | R-b T-b | R-b | R-b |
| 7/16 | R-b T-b | R-b | R-b |
| 8/16 | R-b T-b | R-b | R-b |
| 9/16 | R-b T-b | R-b | R-b |
| 10/16 | R-b T-b | R-b | R-b |
| 11/16 | R-b T-b | R-b | R-b |
| 12/16 | R-b T-b | R-b | R-b |
| 13/16 | R-b T-b | R-b | R-b |
| 14/16 | R-b T-b | R-b | R-b |
| 15/16 | R-b T-b | R-b | R-b |
| 16/16 | R-b T-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v11 00/16] Remove nested TPM operations
Make the changes necessary to detach TPM space code and TPM activation code out of the tpm_transmit() flow because of both of these can cause nested tpm_transmit() calls. The nesteds calls make the whole flow hard to maintain, and thus, it is better to just fix things now before this turns into a bigger mess.
v11:
* Drop the patch that tries to flush TPM space on system. Not a proper fallback + out of scope for this patch set.
v10:
* Use void pointers to avoid unnecessary casts in functions paramaters where it makes sense.
v9:
* Fixed again tpm_try_get_ops().
* Added missing reviewed-by's.
v8:
* Re-add the check for ret < 0 after calling tpm_try_transmit() that was dropped by mistake while moving code.
* Fix error fallback for tpm_try_get_ops() when tpm_chip_start() fails.
v7:
* Reorganize series so that more trivial and self-contained changes are in the head.
v6:
* When tpm_validate_commmand() was moved to tpm2-space.c, the struct for the TPM header was incorrectly declared as struct tpm_input_header.
* Fix return value in tpm_validate_command().
v5:
* Add the missing rev's from Stefan Berger.
v4:
* Return 0 from pcrs_show() when tpm1_pcr_read() fails.
* Fix error handling flow in tpm_try_transmit().
* Replace struct tpm_input_header and struct tpm_output_header with struct tpm_header.
v3:
* Encapsulate power gating code to tpm_chip_start() and tpm_chip_stop().
* Move TPM power gating code and locking to tpm_try_get_ops() and tpm_put_ops().
* Call power gating code directly in tpm_chip_register() and tpm2_del_space().
v2:
* Print tpm2_commit_space() error inside tpm2_commit_space()
* Error code was not printed when recv() callback failed. It is fixed in this version.
* Added a patch that removes @space from tpm_transmit().
* Fixed a regression in earlier series. Forgot to amend the change from the staging area that renames NESTED to UNLOCKED in tpm2-space.c.
Jarkko Sakkinen (16):
tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter
tpm: fix invalid return value in pubek_show()
tpm: return 0 from pcrs_show() when tpm1_pcr_read() fails
tpm: print tpm2_commit_space() error inside tpm2_commit_space()
tpm: declare struct tpm_header
tpm: access command header through struct in tpm_try_transmit()
tpm: encapsulate tpm_dev_transmit()
tpm: clean up tpm_try_transmit() error handling flow
tpm: move tpm_validate_commmand() to tpm2-space.c
tpm: move TPM space code out of tpm_transmit()
tpm: remove @space from tpm_transmit()
tpm: use tpm_try_get_ops() in tpm-sysfs.c.
tpm: remove TPM_TRANSMIT_UNLOCKED flag
tpm: introduce tpm_chip_start() and tpm_chip_stop()
tpm: take TPM chip power gating out of tpm_transmit()
tpm: remove @flags from tpm_transmit()
drivers/char/tpm/tpm-chip.c | 109 ++++++++++++ drivers/char/tpm/tpm-dev-common.c | 44 ++++- drivers/char/tpm/tpm-interface.c | 264 ++++++------------------------ drivers/char/tpm/tpm-sysfs.c | 138 ++++++++++------ drivers/char/tpm/tpm.h | 64 +++----- drivers/char/tpm/tpm1-cmd.c | 28 +--- drivers/char/tpm/tpm2-cmd.c | 72 +++----- drivers/char/tpm/tpm2-space.c | 91 +++++++--- drivers/char/tpm/tpm_i2c_atmel.c | 5 +- drivers/char/tpm/tpm_vtpm_proxy.c | 12 +- drivers/char/tpm/xen-tpmfront.c | 2 +- 11 files changed, 408 insertions(+), 421 deletions(-)
Signature · 1 line
2.19.1