Skip to content

Batch of direct packet access fixes for BPF

Daniel Borkmann netdev 1 version Applied

Status from this message: Applied, Thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7bpf: fix test suite to enable all unpriv program typestools/testing/selftests/bpf/test_verifier.c+13 -20 replies
2/7bpf: disallow direct packet access for unpriv in cg_skbnet/core/filter.c tools/testing/selftests/bpf/test_verifier.c+7 -10 replies
3/7bpf: fix direct packet access for flow dissector progskernel/bpf/verifier.c+4 -20 replies
4/7bpf: fix cg_skb types to hint access type in may_access_direct_pkt_datakernel/bpf/verifier.c+1 -00 replies
5/7bpf: fix direct packet write into pop/peek helperskernel/bpf/helpers.c+0 -21 reply
6/7bpf: fix leaking uninitialized memory on pop/peek helperskernel/bpf/queue_stack_maps.c+2 -01 reply
7/7bpf: make direct packet write unclone more robustkernel/bpf/verifier.c net/core/filter.c+16 -13 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlexei StarovoitovSong LiuMauricio Vasquez B
SeriesA-b
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b A-b
6/7A-b A-b
7/7A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH bpf 0/7] Batch of direct packet access fixes for BPF

Several fixes to get direct packet access in order from verifier side. Also test suite fix to run cg_skb as unpriv and an improvement to make direct packet write less error prone in future.

Thanks!

Daniel Borkmann (7):
bpf: fix test suite to enable all unpriv program types
bpf: disallow direct packet access for unpriv in cg_skb
bpf: fix direct packet access for flow dissector progs
bpf: fix cg_skb types to hint access type in may_access_direct_pkt_data
bpf: fix direct packet write into pop/peek helpers
bpf: fix leaking uninitialized memory on pop/peek helpers
bpf: make direct packet write unclone more robust

 kernel/bpf/helpers.c                        |  2 --
 kernel/bpf/queue_stack_maps.c               |  2 ++
 kernel/bpf/verifier.c                       | 13 ++++++++++---
 net/core/filter.c                           | 17 +++++++++++++++++
 tools/testing/selftests/bpf/test_verifier.c | 15 +++++++++++++--
 5 files changed, 42 insertions(+), 7 deletions(-)
Signature · 1 line
2.9.5

Read the cover letter in its thread