Skip to content

Resending sb/submodule-recursive-fetch-gets-the-tip

Stefan Beller git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 9 repliesIn review
  2. v110 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9sha1-array: provide oid_array_filterDocumentation/technical/api-oid-array.txt sha1-array.c sha1-array.h+25 -00 replies
2/9submodule.c: fix indentationsubmodule.c+6 -30 replies
3/9submodule.c: sort changed_submodule_names before searching itsubmodule.c+2 -11 reply
4/9submodule.c: tighten scope of changed_submodule_names structsubmodule.c+11 -80 replies
5/9submodule: store OIDs in changed_submodule_namessubmodule.c+10 -90 replies
6/9repository: repo_submodule_init to take a submodule structbuiltin/grep.c builtin/ls-files.c builtin/submodule--helper.c +3 more+43 -350 replies
7/9submodule: migrate get_next_submodule to use repository structssubmodule.c+44 -122 replies
8/9submodule.c: fetch in submodules git directory instead of in worktreesubmodule.c+8 -21 reply
9/9fetch: try fetching submodules if needed objects were not fetchedbuiltin/fetch.c submodule.c t/t5526-fetch-submodules.sh+265 -383 replies

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJunio C HamanoJonathan TanJosh SteadmonJonathan Nieder
SeriesR-b T-b
1/9Helped-by
2/9
3/9
4/9
5/9R-b
6/9R-b
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCHv2 0/9] Resending sb/submodule-recursive-fetch-gets-the-tip

This is a resend of sb/submodule-recursive-fetch-gets-the-tip, with all feedback addressed. As it took some time, I'll send it without range-diff, but would ask for full review.

I plan on resending after the next release as this got delayed quite a bit, which is why I also rebased it to master.

Thanks,
Stefan

Previous round:
https://public-inbox.org/git/[email protected]/

Stefan Beller (9):
sha1-array: provide oid_array_filter
submodule.c: fix indentation
submodule.c: sort changed_submodule_names before searching it submodule.c: tighten scope of changed_submodule_names struct
submodule: store OIDs in changed_submodule_names
repository: repo_submodule_init to take a submodule struct
submodule: migrate get_next_submodule to use repository structs submodule.c: fetch in submodules git directory instead of in worktree
fetch: try fetching submodules if needed objects were not fetched

 Documentation/technical/api-oid-array.txt    |   5 +
 builtin/fetch.c                              |  11 +-
 builtin/grep.c                               |  17 +-
 builtin/ls-files.c                           |  12 +-
 builtin/submodule--helper.c                  |   2 +-
 repository.c                                 |  27 +-
 repository.h                                 |  12 +-
 sha1-array.c                                 |  17 ++
 sha1-array.h                                 |   3 +
 submodule.c                                  | 284 ++++++++++++++++---
 t/helper/test-submodule-nested-repo-config.c |   8 +-
 t/t5526-fetch-submodules.sh                  |  86 ++++++
 12 files changed, 395 insertions(+), 89 deletions(-)
Signature · 1 line
2.20.0.rc1.387.gf8505762e3-goog