Skip to content

Refactor ioctl_fibmap() internal interface

Carlos Maiolino linux-fsdevel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 3 repliesIn review
  2. v69 patches 9 repliesSuperseded
  3. v59 patches 19 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v49 patches32 repliesSuperseded
v38 of 9 patches2 repliesSuperseded
v210 patches42 repliesSuperseded
v120 patches30 repliesSuperseded

Changes in v8 from the cover letter

- Rebased over linux-next
- Fix an error in patch 4/5, which led to the wrong value being returned by ioctl_fibmap()

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fs: Enable bmap() function to properly return errorsdrivers/md/md-bitmap.c fs/f2fs/data.c fs/inode.c +3 more+61 -360 replies
2/5cachefiles: drop direct usage of ->bmap method.fs/cachefiles/rdwr.c+14 -132 replies
3/5ecryptfs: drop direct calls to ->bmapfs/ecryptfs/mmap.c+6 -100 replies
4/5fibmap: Use bmap instead of ->bmap method in ioctl_fibmapfs/ioctl.c include/linux/fs.h+28 -110 replies
5/5fibmap: Reject negative block numbersfs/ioctl.c+3 -00 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/5R-b
2/5R-b
3/5R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH V8 0/5] Refactor ioctl_fibmap() internal interface

Hi,

This series refactor the internal structure of FIBMAP so that the filesystem can properly report errors back to VFS, and also simplifies its usage by standardizing all ->bmap() method usage via bmap() function.

The last patch is a bug fix for ioctl_fibmap() calls with negative block values.

Viro spotted a mistake in patch 4/5 on the previous version, where bmap() return value was not being propagated back to userland, breaking its ABI.

So, this new version, only has a change on patch 4/5 to fix this problem.

Changelog:

V8:
- Rebased over linux-next
- Fix an error in patch 4/5, which led to the wrong value being returned by ioctl_fibmap()
V7:

- Rebased over linux-next
- Add parameters names to function declarations

- Remove changelog entries from patches's commit logs

V6:

- Add a dummy bmap() definition so build does not break if CONFIG_BLOCK is not set

- ASSERT only if filesystem does not support bmap() to match the original logic

- Fix bmap() doc function

V5:

- Rebasing against 5.3 required changes to the f2fs check_swap_activate() function

V4:

- Ensure ioctl_fibmap() returns 0 in case of error returned from bmap(). Otherwise we'll be changing the user interface (which returns 0 in case of error)
V3:
- Rename usr_blk to ur_block

V2:
- Use a local sector_t variable to asign the block number instead of using direct casting.

Carlos Maiolino (5):
fs: Enable bmap() function to properly return errors
cachefiles: drop direct usage of ->bmap method.
ecryptfs: drop direct calls to ->bmap
fibmap: Use bmap instead of ->bmap method in ioctl_fibmap
fibmap: Reject negative block numbers

 drivers/md/md-bitmap.c | 16 ++++++++++------
 fs/cachefiles/rdwr.c   | 27 ++++++++++++++-------------
 fs/ecryptfs/mmap.c     | 16 ++++++----------
 fs/f2fs/data.c         | 16 +++++++++++-----
 fs/inode.c             | 30 +++++++++++++++++-------------
 fs/ioctl.c             | 33 +++++++++++++++++++++++----------
 fs/jbd2/journal.c      | 22 +++++++++++++++-------
 include/linux/fs.h     |  9 ++++++++-
 mm/page_io.c           | 11 +++++++----
 9 files changed, 111 insertions(+), 69 deletions(-)
Signature · 1 line
2.23.0