Skip to content

perf tools: Fix for cases where cpumode is incorrect or insufficient

Adrian Hunter lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v15 patches 17 repliesSuperseded

Changes in v2 from the cover letter

perf tools: Add fallback functions for cases where cpumode is insufficient
Rename fallback functions to both end in _fb
Add and use variable machine->single_address_space

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3perf tools: Add fallback functions for cases where cpumode is insufficienttools/perf/arch/common.c tools/perf/arch/common.h tools/perf/util/event.c +4 more+76 -03 replies
2/3perf tools: Use fallback for sample_addr_correlates_sym() casestools/perf/util/event.c+1 -10 replies
3/3perf tools: Use fallbacks for branch stackstools/perf/builtin-script.c tools/perf/util/scripting-engines/trace-event-python.c+14 -140 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchDavid S. Miller
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/3] perf tools: Fix for cases where cpumode is incorrect or insufficient

Hi

Here is V2:
These patches probably deal with most cases except the one fixed by David Miller's "perf callchain: Honour the ordering of PERF_CONTEXT_{USER,KERNEL,etc}" patch, and also cat_backtrace() which looks like it has the same problem, and the cs-etm fix.

Changes in V2:
perf tools: Add fallback functions for cases where cpumode is insufficient
Rename fallback functions to both end in _fb
Add and use variable machine->single_address_space

perf tools: Use fallback for sample_addr_correlates_sym() cases perf tools: Use fallbacks for branch stacks
Adjusted for the re-naming above

perf intel-pt: Insert callchain context into synthesized callchains perf intel-pt/bts: Calculate cpumode for synthesized samples
Dropped because they have been applied

Adrian Hunter (3):
perf tools: Add fallback functions for cases where cpumode is insufficient perf tools: Use fallback for sample_addr_correlates_sym() cases perf tools: Use fallbacks for branch stacks

 tools/perf/arch/common.c                           | 10 ++++++++
 tools/perf/arch/common.h                           |  1 +
 tools/perf/builtin-script.c                        | 12 ++++-----
 tools/perf/util/event.c                            | 29 +++++++++++++++++++++-
 tools/perf/util/machine.c                          | 27 ++++++++++++++++++++
 tools/perf/util/machine.h                          |  3 +++
 .../util/scripting-engines/trace-event-python.c    | 16 ++++++------
 tools/perf/util/session.c                          |  4 +++
 tools/perf/util/thread.h                           |  4 +++
 9 files changed, 91 insertions(+), 15 deletions(-)

Regards
Adrian