Skip to content

drm/sun4i: Allwinner MIPI-DSI Burst mode support

Jagan Teki dri-devel linux-arm-kernel linux-devicetree lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 26 repliesIn review
  2. v110 patches 14 repliesSuperseded

Changes in v2 from the cover letter · 23 lines

- add separate function for setup_inst_delay computation
- moved instruction loop seletion below delay compuation
- add separate function for dsi_get_timings and call for non-burst mode
- simplify burst mode timings compuatation
- add new patches, for tcon0 probing during dsi_bind
- add code to get the tcon0 divider value
- add multiple functions to get line_num, edge0, edge1
- squash 'enable burst mode' patch into 'Setup burst mode'
- fixed commit message of 'Enable burst mode HBP, HSA_HSE' s/enable/disable
- collect Rob R-b tag on panel dt-bindings patch
- panel driver changes,
- dropped unneeded include files
- s/fy07024di26a30d/feiyang function, variable names
- use DRM_DEV_ERROR in panel driver
- add set_display_on .enable
- moved regulator enablement to .prepare
- handle erro statements and release them properly during probe
- remove panel if mipi_dsi_attach failed
- fixed MODULE_LICENSE
- update MAINTAINERS file about the panel
- add comments on dts about exact regulators used in schematics

[1] https://patchwork.kernel.org/cover/10666597/
[2] https://patchwork.kernel.org/cover/10680247/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/sun4i: sun6i_mipi_dsi: Compute burst mode loop N1 instruction delaydrivers/gpu/drm/sun4i/sun6i_mipi_dsi.c+19 -17 replies
2/12drm/sun4i: sun6i_mipi_dsi: Support instruction loop selectiondrivers/gpu/drm/sun4i/sun6i_mipi_dsi.c+3 -00 replies
3/12drm/sun4i: sun6i_mipi_dsi: Setup burst mode timingsdrivers/gpu/drm/sun4i/sun6i_mipi_dsi.c+80 -485 replies
4/12drm/sun4i: sun6i_mipi_dsi: Simplify drq set to support all modesdrivers/gpu/drm/sun4i/sun6i_mipi_dsi.c+23 -154 replies
5/12drm/sun4i: tcon: Export get tcon0 routinedrivers/gpu/drm/sun4i/sun4i_tcon.c drivers/gpu/drm/sun4i/sun4i_tcon.h+3 -11 reply
6/12drm/sun4i: sun6i_mipi_dsi: Probe tcon0 during dsi_binddrivers/gpu/drm/sun4i/sun6i_mipi_dsi.c drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h+8 -03 replies
7/12drm/sun4i: sun6i_mipi_dsi: Setup burst modedrivers/gpu/drm/sun4i/sun6i_mipi_dsi.c+68 -40 replies
8/12drm/sun4i: sun6i_mipi_dsi: Enable 2byte trail for 4-lane burst modedrivers/gpu/drm/sun4i/sun6i_mipi_dsi.c+6 -00 replies
9/12drm/sun4i: sun6i_mipi_dsi: Enable burst mode HBP, HSA_HSEdrivers/gpu/drm/sun4i/sun6i_mipi_dsi.c+9 -30 replies
10/12dt-bindings: panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panelDocumentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt+20 -00 replies
11/12drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panelMAINTAINERS drivers/gpu/drm/panel/Kconfig drivers/gpu/drm/panel/Makefile +1 more+302 -06 replies
12/12arm64: allwinner: a64: pine64-lts: Enable Feiyang FY07024DI26A30-D DSI panelarch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts+37 -00 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12R-b
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/12] drm/sun4i: Allwinner MIPI-DSI Burst mode support

This series support MIPI-DSI Burst mode on Allwinner platform, which is tested in burst supported panel in Pine64-LTS board.

Series fixed few code changes commented in previous version[1] and it depends on A64 MIPI-DSI series[2]

Changes for v2:
- add separate function for setup_inst_delay computation
- moved instruction loop seletion below delay compuation
- add separate function for dsi_get_timings and call for non-burst mode
- simplify burst mode timings compuatation
- add new patches, for tcon0 probing during dsi_bind
- add code to get the tcon0 divider value
- add multiple functions to get line_num, edge0, edge1
- squash 'enable burst mode' patch into 'Setup burst mode'
- fixed commit message of 'Enable burst mode HBP, HSA_HSE' s/enable/disable
- collect Rob R-b tag on panel dt-bindings patch
- panel driver changes,
- dropped unneeded include files
- s/fy07024di26a30d/feiyang function, variable names
- use DRM_DEV_ERROR in panel driver
- add set_display_on .enable
- moved regulator enablement to .prepare
- handle erro statements and release them properly during probe
- remove panel if mipi_dsi_attach failed
- fixed MODULE_LICENSE
- update MAINTAINERS file about the panel
- add comments on dts about exact regulators used in schematics

[1] https://patchwork.kernel.org/cover/10666597/
[2] https://patchwork.kernel.org/cover/10680247/

Any inputs,
Jagan.

Jagan Teki (12):
drm/sun4i: sun6i_mipi_dsi: Compute burst mode loop N1 instruction
delay
drm/sun4i: sun6i_mipi_dsi: Support instruction loop selection drm/sun4i: sun6i_mipi_dsi: Setup burst mode timings
drm/sun4i: sun6i_mipi_dsi: Simplify drq set to support all modes drm/sun4i: tcon: Export get tcon0 routine
drm/sun4i: sun6i_mipi_dsi: Probe tcon0 during dsi_bind
drm/sun4i: sun6i_mipi_dsi: Setup burst mode
drm/sun4i: sun6i_mipi_dsi: Enable 2byte trail for 4-lane burst mode drm/sun4i: sun6i_mipi_dsi: Enable burst mode HBP, HSA_HSE
dt-bindings: panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel
[DO NOT MERGE] arm64: allwinner: a64: pine64-lts: Enable Feiyang FY07024DI26A30-D DSI
panel

 .../display/panel/feiyang,fy07024di26a30d.txt |  20 ++
 MAINTAINERS                                   |   6 +
 .../dts/allwinner/sun50i-a64-pine64-lts.dts   |  37 +++
 drivers/gpu/drm/panel/Kconfig                 |   9 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++
 drivers/gpu/drm/sun4i/sun4i_tcon.c            |   3 +-
 drivers/gpu/drm/sun4i/sun4i_tcon.h            |   1 +
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c        | 264 ++++++++++++----
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h        |   1 +
 10 files changed, 567 insertions(+), 61 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
 create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
Signature · 1 line
2.18.0.321.gffc6fa0e3