Skip to content

s390x/zpci: some hotplug handler cleanups

David Hildenbrand qemu-devel 1 version Applied

Status from this message: queued to s390-next

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 27 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4s390x/zpci: drop msix.availablehw/s390x/s390-pci-bus.c hw/s390x/s390-pci-bus.h+0 -35 replies
2/4s390x/zpci: use hotplug_dev instead of looking up the host bridgehw/s390x/s390-pci-bus.c+2 -27 replies
3/4s390x/zpci: move some hotplug checks to the pre_plug handlerhw/s390x/s390-pci-bus.c+26 -174 replies
4/4s390x/zpci: properly fail if the zPCI device cannot be createdhw/s390x/s390-pci-bus.c+19 -67 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchThomas HuthCollin Walling
1/4R-b R-b
2/4
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups

The hotplug code needs more love, but let's do some obvious cleanups first. In the future, we want to propery make use of unplug_request() + unplug(), instead of routing everything (especially two separate but linked) devices via a single unplug call. Also, we want to move all errors in plug() into the pre_plug() handler, but this will require general PCI refactorings (moving stuff from realize() to the pre_plug/plug handler).

This series is based on "[PATCH v2 00/10] pci: hotplug handler reworks", which contains one cleanup for s390x.

David Hildenbrand (4):
s390x/zpci: drop msix.available
s390x/zpci: use hotplug_dev instead of looking up the host bridge s390x/zpci: move some hotplug checks to the pre_plug handler s390x/zpci: properly fail if the zPCI device cannot be created

 hw/s390x/s390-pci-bus.c | 74 ++++++++++++++++++++++++++---------------
 hw/s390x/s390-pci-bus.h |  1 -
 2 files changed, 47 insertions(+), 28 deletions(-)
Signature · 1 line
2.17.2