Skip to content

Fix/add vmstate handling in some I2C code

[email protected] qemu-devel 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest19 patches 0 repliesNew
  2. v419 patches 2 repliesSuperseded
  3. v316 patches 30 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v212 patches25 repliesSuperseded
v13 patches15 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19i2c: Split smbus into partsMAINTAINERS hw/arm/aspeed.c hw/i2c/Makefile.objs +15 more+285 -1930 replies
2/19i2c: have I2C receive operation return uint8_thw/arm/pxa2xx.c hw/arm/tosa.c hw/arm/z2.c +16 more+37 -440 replies
3/19arm:i2c: Don't mask return from i2c_recv()hw/arm/stellaris.c+1 -10 replies
4/19i2c: Don't check return value from i2c_recv()hw/i2c/aspeed_i2c.c hw/i2c/exynos4210_i2c.c hw/i2c/imx_i2c.c+5 -240 replies
5/19i2c:smbus: Correct the working of quick commandshw/i2c/smbus_slave.c include/hw/i2c/smbus_slave.h+24 -160 replies
6/19i2c:smbus: Simplify write operationhw/i2c/smbus_eeprom.c hw/i2c/smbus_slave.c include/hw/i2c/smbus_slave.h+34 -590 replies
7/19i2c:smbus: Simplify read handlinghw/i2c/smbus_eeprom.c hw/i2c/smbus_slave.c include/hw/i2c/smbus_slave.h+13 -330 replies
8/19i2c:smbus_eeprom: Get rid of the quick commandhw/i2c/smbus_eeprom.c+0 -80 replies
9/19i2c:smbus: Make white space in switch statements consistenthw/i2c/smbus_eeprom.c hw/i2c/smbus_slave.c+10 -00 replies
10/19boards.h: Ignore migration for SMBus devices on older machineshw/i386/pc_piix.c hw/i386/pc_q35.c include/hw/boards.h+3 -00 replies
11/19i2c:pm_smbus: Fix pm_smbus handling of I2C block readhw/i2c/pm_smbus.c include/hw/i2c/pm_smbus.h+73 -190 replies
12/19migration: Add a VMSTATE_BOOL_TEST() macroinclude/migration/vmstate.h+3 -00 replies
13/19i2c:pm_smbus: Fix state transferhw/acpi/piix4.c hw/i2c/pm_smbus.c hw/i2c/smbus_ich9.c +1 more+56 -10 replies
14/19i2c:smbus_slave: Add an SMBus vmstate structurehw/i2c/smbus_slave.c include/hw/i2c/smbus_slave.h+39 -30 replies
15/19i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.chw/i2c/smbus_eeprom.c+10 -50 replies
16/19i2c:smbus_eeprom: Add a size constant for the smbus_eeprom sizehw/i2c/smbus_eeprom.c+7 -30 replies
17/19i2c:smbus_eeprom: Add vmstate handling to the smbus eepromhw/i2c/smbus_eeprom.c+32 -20 replies
18/19i2c:smbus_eeprom: Add a reset function to smbus_eepromhw/i2c/smbus_eeprom.c+17 -10 replies
19/19i2c: Verify that the count passed in to smbus_eeprom_init() is validhw/i2c/smbus_eeprom.c+2 -00 replies

Reviews trailers per patch

11 of 19 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellPhilippe Mathieu-DaudéDr. David Alan Gilbert
1/19R-b T-b
2/19R-b R-b T-b
3/19R-b R-b T-b
4/19
5/19
6/19
7/19
8/19
9/19
10/19R-b
11/19
12/19R-b
13/19R-b
14/19R-b
15/19R-b R-b
16/19R-b
17/19R-b
18/19R-b
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH v5 00/19] Fix/add vmstate handling in some I2C code

I haven't received any other comments on this except for the one below. I think this is ready for inclusion.

Changes since v4:

Fixed the stupid thinko I did in "boards.h: Ignore migration for SMBus devices on older machines", Put it in the 3.1 function so it's actually an older machine.

Changes since v3:

Change I2C to "I2C and SMBus" in the MAINTAINERS file.

Added a comment to the smbus_eeprom reset to make the reasoning for the choice clear.

Fix a logic error introduced in "i2c: Don't check return value from i2c_recv()".

Fix a debug problem in "i2c: Simplify and correct the SMBus state machine", a removed variable was still being used in a debug statement.

Split up "i2c: Simplify and correct the SMBus state machine" into smaller logical chunks.

Updated "boards.h: Ignore migration for SMBus devices on older machines" to ignore migration for 4.0 and earlier.

No other comments received on "i2c:smbus_eeprom: Add vmstate handling to the smbus eeprom", not sure what to make of that. I think that Dave's response to my question was that it could be modified to support different sizes in the future without issue.

Dropped "hw/i2c/smbus_eeprom: Create at most SMBUS_EEPROM_MAX EEPROMs on a SMBus and instead added a patch to assert if the number of eeproms is > 8.

Changes since v2:

Added proper license headers for the newly created files.

Removed unneeded code in several places pointed out by Peter Maydell since i2c_recv() returns a uint8_t instead of an int. These are in two separate patches.
Added a patch from Philippe Mathieu-Daudé <[email protected]> to replace a magic number with a constant in the smbus_eeprom code and verify the count so there is no overflow.

Updated the pm_smbus migration to not update the version numbers in the existing vmstate structures. The needed field didn't accomplish what was needed because it is only called on the save side, not the load side of the migration. So I'm using VMSTATE_STRUCT_TEST() to transfer the pm_smbus data now, that should be all that is required for backwards compatibility, and will be safer for falling back to an older version.

I found the problem with the SMBus being broken on piix4 after a migration, but I sent it out as a separate patch since it has nothing to do with this series, and should probably go into the current release being worked on.