Fix/add vmstate handling in some I2C code
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest19 patches 0 repliesNew
- v419 patches 2 repliesSuperseded
- v316 patches 30 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 12 patches | 25 replies | Superseded | |
| v1 | 3 patches | 15 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | i2c: Split smbus into partsMAINTAINERS hw/ hw/ +15 more | +285 | 0 replies | |
| 2/19 | i2c: have I2C receive operation return uint8_thw/ hw/ hw/ +16 more | +37 | 0 replies | |
| 3/19 | arm:i2c: Don't mask return from i2c_recv()hw/ | +1 | 0 replies | |
| 4/19 | i2c: Don't check return value from i2c_recv()hw/ hw/ hw/ | +5 | 0 replies | |
| 5/19 | i2c:smbus: Correct the working of quick commandshw/ include/ | +24 | 0 replies | |
| 6/19 | i2c:smbus: Simplify write operationhw/ hw/ include/ | +34 | 0 replies | |
| 7/19 | i2c:smbus: Simplify read handlinghw/ hw/ include/ | +13 | 0 replies | |
| 8/19 | i2c:smbus_eeprom: Get rid of the quick commandhw/ | +0 | 0 replies | |
| 9/19 | i2c:smbus: Make white space in switch statements consistenthw/ hw/ | +10 | 0 replies | |
| 10/19 | boards.h: Ignore migration for SMBus devices on older machineshw/ hw/ include/ | +3 | 0 replies | |
| 11/19 | i2c:pm_smbus: Fix pm_smbus handling of I2C block readhw/ include/ | +73 | 0 replies | |
| 12/19 | migration: Add a VMSTATE_BOOL_TEST() macroinclude/ | +3 | 0 replies | |
| 13/19 | i2c:pm_smbus: Fix state transferhw/ hw/ hw/ +1 more | +56 | 0 replies | |
| 14/19 | i2c:smbus_slave: Add an SMBus vmstate structurehw/ include/ | +39 | 0 replies | |
| 15/19 | i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.chw/ | +10 | 0 replies | |
| 16/19 | i2c:smbus_eeprom: Add a size constant for the smbus_eeprom sizehw/ | +7 | 0 replies | |
| 17/19 | i2c:smbus_eeprom: Add vmstate handling to the smbus eepromhw/ | +32 | 0 replies | |
| 18/19 | i2c:smbus_eeprom: Add a reset function to smbus_eepromhw/ | +17 | 0 replies | |
| 19/19 | i2c: Verify that the count passed in to smbus_eeprom_init() is validhw/ | +2 | 0 replies |
Reviews trailers per patch
11 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Peter Maydell | Philippe Mathieu-Daudé | Dr. David Alan Gilbert |
|---|---|---|---|
| 1/19 | R-b T-b | ||
| 2/19 | R-b | R-b T-b | |
| 3/19 | R-b | R-b T-b | |
| 4/19 | |||
| 5/19 | |||
| 6/19 | |||
| 7/19 | |||
| 8/19 | |||
| 9/19 | |||
| 10/19 | R-b | ||
| 11/19 | |||
| 12/19 | R-b | ||
| 13/19 | R-b | ||
| 14/19 | R-b | ||
| 15/19 | R-b | R-b | |
| 16/19 | R-b | ||
| 17/19 | R-b | ||
| 18/19 | R-b | ||
| 19/19 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v5 00/19] Fix/add vmstate handling in some I2C code
I haven't received any other comments on this except for the one below. I think this is ready for inclusion.
Changes since v4:
Fixed the stupid thinko I did in "boards.h: Ignore migration for SMBus devices on older machines", Put it in the 3.1 function so it's actually an older machine.
Changes since v3:
Change I2C to "I2C and SMBus" in the MAINTAINERS file.
Added a comment to the smbus_eeprom reset to make the reasoning for the choice clear.
Fix a logic error introduced in "i2c: Don't check return value from i2c_recv()".
Fix a debug problem in "i2c: Simplify and correct the SMBus state machine", a removed variable was still being used in a debug statement.
Split up "i2c: Simplify and correct the SMBus state machine" into smaller logical chunks.
Updated "boards.h: Ignore migration for SMBus devices on older machines" to ignore migration for 4.0 and earlier.
No other comments received on "i2c:smbus_eeprom: Add vmstate handling to the smbus eeprom", not sure what to make of that. I think that Dave's response to my question was that it could be modified to support different sizes in the future without issue.
Dropped "hw/i2c/smbus_eeprom: Create at most SMBUS_EEPROM_MAX EEPROMs on a SMBus and instead added a patch to assert if the number of eeproms is > 8.
Changes since v2:
Added proper license headers for the newly created files.
Removed unneeded code in several places pointed out by Peter Maydell since i2c_recv() returns a uint8_t instead of an int. These are in two separate patches.
Added a patch from Philippe Mathieu-Daudé <[email protected]> to replace a magic number with a constant in the smbus_eeprom code and verify the count so there is no overflow.
Updated the pm_smbus migration to not update the version numbers in the existing vmstate structures. The needed field didn't accomplish what was needed because it is only called on the save side, not the load side of the migration. So I'm using VMSTATE_STRUCT_TEST() to transfer the pm_smbus data now, that should be all that is required for backwards compatibility, and will be safer for falling back to an older version.
I found the problem with the SMBus being broken on piix4 after a migration, but I sent it out as a separate patch since it has nothing to do with this series, and should probably go into the current release being worked on.