bpftool: support loading flow dissector
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest7 patches 8 repliesIn review
- v34 patches 13 repliesSuperseded
- v23 patches 11 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 11 replies | Superseded |
Changes in v5 from the cover letter
* FILE -> PATH for load/loadall (can be either file or directory now)
* simpler implementation for __bpf_program__pin_name
* removed p_err for REQ_ARGS checks
* parse_atach_detach_args -> parse_attach_detach_args
* for -> while in bpf_object__pin_{programs,maps} recovery
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | selftests/bpf: rename flow dissector section to flow_dissectortools/ tools/ | +2 | 0 replies | |
| 2/7 | libbpf: cleanup after partial failure in bpf_object__pintools/ tools/ | +319 | 5 replies | |
| 3/7 | libbpf: bpf_program__pin: add special case for instances.nr == 1tools/ | +10 | 0 replies | |
| 4/7 | libbpf: add internal pin_nametools/ | +26 | 0 replies | |
| 5/7 | bpftool: add loadall commandtools/ tools/ tools/ +2 more | +81 | 0 replies | |
| 6/7 | bpftool: add pinmaps argument to the load/loadalltools/ tools/ tools/ | +28 | 0 replies | |
| 7/7 | bpftool: support loading flow dissectortools/ tools/ tools/ | +74 | 0 replies |
Reviews trailers per patch
3 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jakub Kicinski | Quentin Monnet |
|---|---|---|
| Series | A-b | |
| 1/7 | ||
| 2/7 | ||
| 3/7 | ||
| 4/7 | ||
| 5/7 | A-b | |
| 6/7 | A-b | |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 bpf-next 0/7] bpftool: support loading flow dissector
v5 changes:
* FILE -> PATH for load/loadall (can be either file or directory now)
* simpler implementation for __bpf_program__pin_name
* removed p_err for REQ_ARGS checks
* parse_atach_detach_args -> parse_attach_detach_args
* for -> while in bpf_object__pin_{programs,maps} recovery
v4 changes:
* addressed another round of comments/style issues from Jakub Kicinski & Quentin Monnet (thanks!)
* implemented bpf_object__pin_maps and bpf_object__pin_programs helpers and used them in bpf_program__pin
* added new pin_name to bpf_program so bpf_program__pin
works with sections that contain '/'
* moved *loadall* command implementation into a separate patch
* added patch that implements *pinmaps* to pin maps when doing load/loadall
v3 changes:
* (maybe) better cleanup for partial failure in bpf_object__pin
* added special case in bpf_program__pin for programs with single instances
v2 changes:
* addressed comments/style issues from Jakub Kicinski & Quentin Monnet
* removed logic that populates jump table
* added cleanup for partial failure in bpf_object__pin
This patch series adds support for loading and attaching flow dissector programs from the bpftool:
* first patch fixes flow dissector section name in the selftests (so libbpf auto-detection works)
* second patch adds proper cleanup to bpf_object__pin, parts of which are now being used to attach all flow dissector progs/maps
* third patch adds special case in bpf_program__pin for programs with single instances (we don't create <prog>/0 pin anymore, just <prog>)
* forth patch adds pin_name to the bpf_program struct
which is now used as a pin name in bpf_program__pin et al
* fifth patch adds *loadall* command that pins all programs, not just the first one
* sixth patch adds *pinmaps* argument to load/loadall to let users pin all maps of the obj file
* seventh patch adds actual flow_dissector support to the bpftool and an example
Stanislav Fomichev (7):
selftests/bpf: rename flow dissector section to flow_dissector
libbpf: cleanup after partial failure in bpf_object__pin
libbpf: bpf_program__pin: add special case for instances.nr == 1
libbpf: add internal pin_name
bpftool: add loadall command
bpftool: add pinmaps argument to the load/loadall
bpftool: support loading flow dissector
.../bpftool/Documentation/bpftool-prog.rst | 42 +- tools/bpf/bpftool/bash-completion/bpftool | 21 +- tools/bpf/bpftool/common.c | 31 +- tools/bpf/bpftool/main.h | 1 + tools/bpf/bpftool/prog.c | 183 ++++++--- tools/lib/bpf/libbpf.c | 359 ++++++++++++++++-- tools/lib/bpf/libbpf.h | 18 + tools/testing/selftests/bpf/bpf_flow.c | 2 +- .../selftests/bpf/test_flow_dissector.sh | 2 +- 9 files changed, 537 insertions(+), 122 deletions(-)
Signature · 1 line
2.19.1.930.g4563a0d9d0-goog