Skip to content

bpftool: support loading flow dissector

Stanislav Fomichev linux-kselftest netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 8 repliesIn review
  2. v34 patches 13 repliesSuperseded
  3. v23 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches11 repliesSuperseded

Changes in v5 from the cover letter

* FILE -> PATH for load/loadall (can be either file or directory now)
* simpler implementation for __bpf_program__pin_name
* removed p_err for REQ_ARGS checks
* parse_atach_detach_args -> parse_attach_detach_args
* for -> while in bpf_object__pin_{programs,maps} recovery

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7selftests/bpf: rename flow dissector section to flow_dissectortools/testing/selftests/bpf/bpf_flow.c tools/testing/selftests/bpf/test_flow_dissector.sh+2 -20 replies
2/7libbpf: cleanup after partial failure in bpf_object__pintools/lib/bpf/libbpf.c tools/lib/bpf/libbpf.h+319 -235 replies
3/7libbpf: bpf_program__pin: add special case for instances.nr == 1tools/lib/bpf/libbpf.c+10 -00 replies
4/7libbpf: add internal pin_nametools/lib/bpf/libbpf.c+26 -30 replies
5/7bpftool: add loadall commandtools/bpf/bpftool/Documentation/bpftool-prog.rst tools/bpf/bpftool/bash-completion/bpftool tools/bpf/bpftool/common.c +2 more+81 -430 replies
6/7bpftool: add pinmaps argument to the load/loadalltools/bpf/bpftool/Documentation/bpftool-prog.rst tools/bpf/bpftool/bash-completion/bpftool tools/bpf/bpftool/prog.c+28 -30 replies
7/7bpftool: support loading flow dissectortools/bpf/bpftool/Documentation/bpftool-prog.rst tools/bpf/bpftool/bash-completion/bpftool tools/bpf/bpftool/prog.c+74 -510 replies

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJakub KicinskiQuentin Monnet
SeriesA-b
1/7
2/7
3/7
4/7
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 bpf-next 0/7] bpftool: support loading flow dissector

v5 changes:
* FILE -> PATH for load/loadall (can be either file or directory now)
* simpler implementation for __bpf_program__pin_name
* removed p_err for REQ_ARGS checks
* parse_atach_detach_args -> parse_attach_detach_args
* for -> while in bpf_object__pin_{programs,maps} recovery

v4 changes:
* addressed another round of comments/style issues from Jakub Kicinski & Quentin Monnet (thanks!)
* implemented bpf_object__pin_maps and bpf_object__pin_programs helpers and used them in bpf_program__pin
* added new pin_name to bpf_program so bpf_program__pin
works with sections that contain '/'
* moved *loadall* command implementation into a separate patch
* added patch that implements *pinmaps* to pin maps when doing load/loadall

v3 changes:
* (maybe) better cleanup for partial failure in bpf_object__pin
* added special case in bpf_program__pin for programs with single instances

v2 changes:
* addressed comments/style issues from Jakub Kicinski & Quentin Monnet
* removed logic that populates jump table
* added cleanup for partial failure in bpf_object__pin

This patch series adds support for loading and attaching flow dissector programs from the bpftool:

* first patch fixes flow dissector section name in the selftests (so libbpf auto-detection works)
* second patch adds proper cleanup to bpf_object__pin, parts of which are now being used to attach all flow dissector progs/maps
* third patch adds special case in bpf_program__pin for programs with single instances (we don't create <prog>/0 pin anymore, just <prog>)
* forth patch adds pin_name to the bpf_program struct
which is now used as a pin name in bpf_program__pin et al
* fifth patch adds *loadall* command that pins all programs, not just the first one
* sixth patch adds *pinmaps* argument to load/loadall to let users pin all maps of the obj file
* seventh patch adds actual flow_dissector support to the bpftool and an example

Stanislav Fomichev (7):
selftests/bpf: rename flow dissector section to flow_dissector
libbpf: cleanup after partial failure in bpf_object__pin
libbpf: bpf_program__pin: add special case for instances.nr == 1
libbpf: add internal pin_name
bpftool: add loadall command
bpftool: add pinmaps argument to the load/loadall
bpftool: support loading flow dissector

 .../bpftool/Documentation/bpftool-prog.rst    |  42 +-
 tools/bpf/bpftool/bash-completion/bpftool     |  21 +-
 tools/bpf/bpftool/common.c                    |  31 +-
 tools/bpf/bpftool/main.h                      |   1 +
 tools/bpf/bpftool/prog.c                      | 183 ++++++---
 tools/lib/bpf/libbpf.c                        | 359 ++++++++++++++++--
 tools/lib/bpf/libbpf.h                        |  18 +
 tools/testing/selftests/bpf/bpf_flow.c        |   2 +-
 .../selftests/bpf/test_flow_dissector.sh      |   2 +-
 9 files changed, 537 insertions(+), 122 deletions(-)
Signature · 1 line
2.19.1.930.g4563a0d9d0-goog