Skip to content

Lochnagar Driver

Charles Keepax linux-clk linux-devicetree linux-gpio lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest6 patches 7 repliesIn review

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6regulator: lochnagar: Explicitly include register headersdrivers/regulator/lochnagar-regulator.c+2 -00 replies
2/6regulator: lochnagar: Move driver to binding from DTdrivers/regulator/lochnagar-regulator.c+7 -12 replies
3/6mfd: lochnagar: Add initial binding documentationDocumentation/devicetree/bindings/clock/cirrus,lochnagar.txt Documentation/devicetree/bindings/mfd/cirrus,lochnagar.txt Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.txt +3 more+538 -02 replies
4/6mfd: lochnagar: Add support for the Cirrus Logic LochnagarMAINTAINERS drivers/mfd/Kconfig drivers/mfd/Makefile +4 more+886 -01 reply
5/6clk: lochnagar: Add support for the Cirrus Logic Lochnagardrivers/clk/Kconfig drivers/clk/Makefile drivers/clk/clk-lochnagar.c+368 -00 replies
6/6pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagardrivers/pinctrl/cirrus/Kconfig drivers/pinctrl/cirrus/Makefile drivers/pinctrl/cirrus/pinctrl-lochnagar.c +1 more+1269 -02 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchLee JonesLinus Walleij
1/6
2/6
3/6Acked-for-MFD-by
4/6Acked-for-MFD-by
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] Lochnagar Driver

Version 4 of this series the big change here is splitting up the device tree into having a node for each of the MFD child drivers. More detailed change logs are given on each patch.

Lee doesn't like the idea of having both mfd_add_devices and of_platform_populate in the MFD driver. Stephen had asked on a previous spin to move the fixed clocks out of the clock driver into device tree and there is a fixed regulator as well that is specified through device tree. Those require having the of_platform_populate there which left the only solution being to move the MFD children into device tree as well.

I have moved the relevant DT settings to be attached to their respective nodes in DT although I guess another option would be to leave all the config on the parent node and just use the child nodes for binding in the drivers, but I decided that was less consistent with other DT usage. But could switch over to it if people prefer.

Thanks,
Charles

Charles Keepax (6):
regulator: lochnagar: Explicitly include register headers
regulator: lochnagar: Move driver to binding from DT
mfd: lochnagar: Add initial binding documentation
mfd: lochnagar: Add support for the Cirrus Logic Lochnagar
clk: lochnagar: Add support for the Cirrus Logic Lochnagar
pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar

 .../devicetree/bindings/clock/cirrus,lochnagar.txt |   89 ++
 .../devicetree/bindings/mfd/cirrus,lochnagar.txt   |   70 ++
 .../bindings/pinctrl/cirrus,lochnagar.txt          |  141 +++
 .../bindings/regulator/cirrus,lochnagar.txt        |   80 ++
 MAINTAINERS                                        |   17 +
 drivers/clk/Kconfig                                |    7 +
 drivers/clk/Makefile                               |    1 +
 drivers/clk/clk-lochnagar.c                        |  360 ++++++
 drivers/mfd/Kconfig                                |    8 +
 drivers/mfd/Makefile                               |    2 +
 drivers/mfd/lochnagar-i2c.c                        |  394 +++++++
 drivers/pinctrl/cirrus/Kconfig                     |   10 +
 drivers/pinctrl/cirrus/Makefile                    |    2 +
 drivers/pinctrl/cirrus/pinctrl-lochnagar.c         | 1145 ++++++++++++++++++++
 drivers/pinctrl/cirrus/pinctrl-lochnagar.h         |  112 ++
 drivers/regulator/lochnagar-regulator.c            |   10 +-
 include/dt-bindings/clk/lochnagar.h                |   26 +
 include/dt-bindings/pinctrl/lochnagar.h            |  132 +++
 include/linux/mfd/lochnagar.h                      |   55 +
 include/linux/mfd/lochnagar1_regs.h                |  157 +++
 include/linux/mfd/lochnagar2_regs.h                |  253 +++++
 21 files changed, 3070 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/clock/cirrus,lochnagar.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/cirrus,lochnagar.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/cirrus,lochnagar.txt
 create mode 100644 drivers/clk/clk-lochnagar.c
 create mode 100644 drivers/mfd/lochnagar-i2c.c
 create mode 100644 drivers/pinctrl/cirrus/pinctrl-lochnagar.c
 create mode 100644 drivers/pinctrl/cirrus/pinctrl-lochnagar.h
 create mode 100644 include/dt-bindings/clk/lochnagar.h
 create mode 100644 include/dt-bindings/pinctrl/lochnagar.h
 create mode 100644 include/linux/mfd/lochnagar.h
 create mode 100644 include/linux/mfd/lochnagar1_regs.h
 create mode 100644 include/linux/mfd/lochnagar2_regs.h
Signature · 1 line
2.11.0