Add queue_is_busy helper
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 10 repliesIn review
- v12 patches 4 repliesSuperseded
Changes in v2 from the cover letter
- Remember to check if the queue matches, otherwise we could be returning false positive for shared tag sets.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | blk-mq-tag: change busy_iter_fn to return whether to continue or notblock/ block/ block/ +1 more | +18 | 6 replies | |
| 2/2 | blk-mq: provide a helper to check if a queue is busyblock/ include/ | +28 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Mike Snitzer | Bart Van Assche |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHSET v2 0/2] Add queue_is_busy helper
DM currently uses atomic inc/dec to maintain a busy count of IO on a given device. For the dm-mq path, we can replace this with helper that just checks the state of the tags on the device.
First patch is a prep patch that allows the iteration helpers to return true/false, like we support internally in sbitmap. For a busy check we don't care about how many requests are busy, just if some are or not. Hence we can stop iterating tags as soon as we find one that is allocated.
Changes since v1:
- Remember to check if the queue matches, otherwise we could be returning false positive for shared tag sets.
block/blk-mq-debugfs.c | 4 +++- block/blk-mq-tag.c | 4 ++-- block/blk-mq.c | 42 +++++++++++++++++++++++++++++++++++++----- include/linux/blk-mq.h | 6 ++++-- 4 files changed, 46 insertions(+), 10 deletions(-)
Signature · 1 line
Jens Axboe