Skip to content

RFC qapi: rewrite string-input-visitor

David Hildenbrand qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6cutils: add qemu_strtod()include/qemu/cutils.h util/cutils.c+23 -00 replies
2/6qapi: use qemu_strtod() in string-input-visitorqapi/string-input-visitor.c+2 -45 replies
3/6qapi: rewrite string-input-visitorinclude/qapi/string-input-visitor.h qapi/string-input-visitor.c tests/test-string-input-visitor.c+264 -1935 replies
4/6test-string-input-visitor: use virtual walktests/test-string-input-visitor.c+12 -240 replies
5/6test-string-input-visitor: split off uint64 list teststests/test-string-input-visitor.c+67 -43 replies
6/6test-string-input-visitor: add range overflow teststests/test-string-input-visitor.c+10 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH RFC 0/6] qapi: rewrite string-input-visitor

Rewrite string-input-visitor to be (hopefully) less ugly. Support int and uint lists (including ranges, but not implemented via type "Range").

Virtual walks are now supported and more errors are cought (and some bugs fixed). Fix and extend the tests. Parsing of uint64_t is now properly supported.

Importantly, when parsing a list we now return the list and not an ordered set (we are not an ordered set parser after all). Whoever needs that can add it on top. As far as I can see, current code can deal with it but I'll have to look at the details.

Guess once this part here is done, the output visitor is the next thing to rework.

David Hildenbrand (6):
cutils: add qemu_strtod()
qapi: use qemu_strtod() in string-input-visitor
qapi: rewrite string-input-visitor
test-string-input-visitor: use virtual walk
test-string-input-visitor: split off uint64 list tests
test-string-input-visitor: add range overflow tests

 include/qapi/string-input-visitor.h |   3 +-
 include/qemu/cutils.h               |   1 +
 qapi/string-input-visitor.c         | 444 ++++++++++++++++------------
 tests/test-string-input-visitor.c   | 131 +++++---
 util/cutils.c                       |  22 ++
 5 files changed, 377 insertions(+), 224 deletions(-)
Signature · 1 line
2.17.2