serial: Finish sysrq on qcom_geni; fix sysrq vs. lockdep on 8250
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest0 of 5 patches 0 repliesNew
Patches in v2 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/5] serial: Finish sysrq on qcom_geni; fix sysrq vs. lockdep on 8250
Quoted 22 lines · Douglas Anderson
I started out this series trying to make sysrq work over the serial console on
qcom_geni_serial, then fell into a rat's nest.To solve the deadlock I faced when enabling sysrq I tried to borrow code from '
8250_port.c' which avoided grabbing the port lock inconsole_write(). ...but since these days I try to run with lockdep on all the time, I found it caused an annoying lockdep splat (which I also reproduced on my rk3399 board). ...so I instead changed myqcom_geni_serialsolution to borrow code from 'msm_serial.c'I wasn't super happy with the solution in '
msm_serial.c' though. I don't like releasing the spinlock there. Not only is it ugly but it means we are unlocking / re-locking_allthetime_even though sysrq characters are rare. ...so I came up with what I think is a better solution and then implemented it forqcom_geni_serial.Since I had a good way to test 8250-based UARTs, I also fixed that driver to use my new method. When doing so, I ran into a missing include in
serial_core.h. NOTE: I didn't have a way to testmsm_serial.cat all, so I didn't switch that (or all other serial drivers for that matter) to the new method.
Quoted 4 lines
NOTE: from a serial point of view v2 is the same as v1 but I've removed the extra kgdb-related patches and made it obvious that this is really for all sysrq, not just kgdb. I've also generally tried to curate the CCs more properly.
Looks good, thanks for cleaning this up. All now queued up.
greg k-h