Skip to content

mtd: Fix partition handling code

Boris Brezillon u-boot 1 version New

Get series with b4
b4 am 20181110122359.430c6314@bbrezillon

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/3] mtd: Fix partition handling code
Quoted 35 lines · On Sat, 10 Nov 2018 16:57:07 +0530 Jagan Teki <[email protected]>…
Quoted 33 lines · Boris Brezillon
Quoted 28 lines · On Sat, 10 Nov 2018 15:02:05 +0530 Jagan Teki <[email protected]>…
Quoted 16 lines · Jagan Teki
Quoted 13 lines · Boris Brezillon

Hello,

Stefan recently reported a bug when using ubi part on a spi-nand device and proposed this fix[1]. While his solution while working I proposed a different approach to kill the CMD_UBI dependency on CMD_MTDPARTS. This is what patches 1 and 2 are doing.

Patch 3 is just removing the duplicate Kconfig MTD_PARTITIONS entry.

Jagan, can you queue those patches to one of your branch and send a fixes PR, unless Tom prefers to take them directly.

Quoted 8 lines
Quoted 8 lines

Regards,

Boris

Boris Brezillon (3):
mtd: Use default mtdparts/mtids when not defined in the environment
cmd: ubi: Remove useless call to mtdparts_init()
mtd: Drop duplicate MTD_PARTITIONS Kconfig option

Did you find this build issues? [1]
https://travis-ci.org/openedev/u-boot-amarula/builds/450798634

Quoted 7 lines
Quoted 4 lines

If by find you mean notice, then no, but I just sent 2 patches to fix the problems.

Thanks for reporting the bugs.

Look like enabling CMD_MTDPARTS=y to relevant defconfigs were fine, since other boards did the same. I made change trigger a build [2]

Well, there's still a problem with dependencies. For instance, DFU_NAND should select CMD_MTDPARTS since it's using a function exposed by cmd/mtdparts.c. For sure, adding CMD_MTDPARTS=y to existing defconfigs does the trick, but it's not the correct fix IMHO.

Quoted 2 lines

[2] https://travis-ci.org/openedev/u-boot-amarula/builds/453235656

Read the cover letter in its thread