Skip to content

Deferred client-connect patch set

Arne Schwabe openvpn-devel 2 versions – NAK

Status from this message: NAK.

Get series with b4
b4 am [email protected]...

Versions newest first · linked by author and title

  1. v4 Latest13 patches 4 repliesNAK
  2. v313 patches 0 repliesSuperseded

Patches in v4

#Subject and filesSizeRepliesApplied
1/13client-connect: Split multi_connection_established into separate functionssrc/openvpn/multi.c src/openvpn/multi.h+346 -2552 replies
2/13client-connect: Refactor multi_client_connect_source_ccdsrc/openvpn/multi.c+15 -161 reply
3/13client-connect: Move multi_client_connect_setenv into early_setupsrc/openvpn/multi.c+14 -91 reply
4/13client-connect: Refactor to use return values instead of modifying a passed-in flagsrc/openvpn/multi.c src/openvpn/multi.h+87 -490 replies
5/13client-connect: Refactor client-connect handling to calling a bunch of hooks in a loopsrc/openvpn/multi.c+16 -280 replies
6/13client-connect: Change connection_established_flag from bool to enumsrc/openvpn/multi.c src/openvpn/multi.h+18 -100 replies
7/13client-connect: Add CC_RET_DEFERRED and cope with deferred client-connectsrc/openvpn/multi.c src/openvpn/multi.h+137 -400 replies
8/13client-connect: Add deferred support to the client-connect script handlersrc/openvpn/multi.c src/openvpn/multi.h+229 -150 replies
9/13client-connect: Move adding inotify watch into its own functionsrc/openvpn/multi.c+30 -160 replies
10/13client-connect: Also use inotify for the deferred client-connect status filesrc/openvpn/multi.c+13 -30 replies
11/13client-connect: Add deferred support to the client-connect plugin v1 handlerinclude/openvpn-plugin.h.in src/openvpn/multi.c src/openvpn/plugin.c+94 -360 replies
12/13client-connect: Implement deferred connect support for plugin API v2src/openvpn/multi.c src/openvpn/plugin.c+50 -110 replies
13/13client-connect: Add documentation for the deferred client connect featuredoc/openvpn.8 include/openvpn-plugin.h.in+59 -91 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [Openvpn-devel] [PATCH v4 00/13] Deferred client-connect patch set

Fabian submitted the original patch set in 2015. When I started working on it I had quite big rebase conflicts and decided to rebsae it manually. During this rebase I adjusted the code and made other minor and major adjustments to the code to better fit our current code style. The minor adjustments are mostly not mentioned in the commit message. The larger changes are mentioned or if feasible and sensible in their own commits.

The V4 patch fixes minor code style problems, spotted by uncrustify. Since modifying the first patch creates merge conflicts in all other patches, the whole patch series is rebased and resend. The patches themsevles do not have a V4 item in them that mentions this reformatting.

Arne Schwabe (5):
client-connect: Change connection_established_flag from bool to enum
client-connect: Move adding inotify watch into its own function
client-connect: Also use inotify for the deferred client-connect
status file
client-connect: Implement deferred connect support for plugin API v2
client-connect: Add documentation for the deferred client connect
feature

Fabian Knittel (8):
client-connect: Split multi_connection_established into separate
functions
client-connect: Refactor multi_client_connect_source_ccd
client-connect: Move multi_client_connect_setenv into early_setup
client-connect: Refactor to use return values instead of modifying a
passed-in flag
client-connect: Refactor client-connect handling to calling a bunch of
hooks in a loop
client-connect: Add CC_RET_DEFERRED and cope with deferred
client-connect
client-connect: Add deferred support to the client-connect script
handler
client-connect: Add deferred support to the client-connect plugin v1
handler

 doc/openvpn.8               |   47 +-
 include/openvpn-plugin.h.in |   51 +-
 src/openvpn/multi.c         | 1045 ++++++++++++++++++++++++++---------
 src/openvpn/multi.h         |   52 +-
 src/openvpn/plugin.c        |    6 +
 5 files changed, 906 insertions(+), 295 deletions(-)
Signature · 1 line
2.19.1