Avoid confusing messages from new index extensions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 24 repliesIn review
- v13 patches 21 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | eoie: default to not writing EOIE sectionDocumentation/ read-cache.c t/ | +24 | 5 replies | |
| 2/5 | ieot: default to not writing IEOT sectionDocumentation/ read-cache.c | +17 | 5 replies | |
| 3/5 | index: do not warn about unrecognized extensionsread-cache.c | +1 | 0 replies | |
| 4/5 | index: make index.threads=true enable ieot and eoieDocumentation/ config.c config.h +1 more | +32 | 1 reply | |
| 5/5 | index: offer advice for unknown index extensionsadvice.c advice.h read-cache.c | +14 | 13 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by.
| Patch | Ben Peart | Junio C Hamano |
|---|---|---|
| 1/5 | ||
| 2/5 | ||
| 3/5 | ||
| 4/5 | Helped-by | |
| 5/5 | Helped-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] Avoid confusing messages from new index extensions
Quoted 8 lines · Junio C Hamano
Quoted 2 lines · Ben Peart
Why introduce a new setting to disable writing the IEOT extension instead of just using the existing index.threads setting?
But index.threads is about what the reader does, not about the writer who does not even know who will be reading the resulting index, no?
It affects the writer, too, since it affects the number of blocks, but from an end user's point of view, I agree.
Here's an updated version of the series.
Patches 1-3 are as before, except that they are rebased to avoid conflicting with nd/config-split.
Patch 4 allows enabling the new index extensions with a single config setting, to address the feedback above.
Patch 5 revives the noisiness when encountering an unknown index extension, guarded with an advice setting.
Sorry for the delay in getting this out. Thoughts of all kinds welcome, as always.
Sincerely,
Jonathan Nieder (5):
eoie: default to not writing EOIE section
ieot: default to not writing IEOT section
index: do not warn about unrecognized extensions
index: make index.threads=true enable ieot and eoie
index: offer advice for unknown index extensions
Documentation/config/index.txt | 16 ++++++++++ advice.c | 2 ++ advice.h | 1 + config.c | 17 ++++++----- config.h | 2 +- read-cache.c | 54 +++++++++++++++++++++++++++++----- t/t1700-split-index.sh | 11 ++++--- 7 files changed, 84 insertions(+), 19 deletions(-)