Skip to content

scsi timeout handling updates

Keith Busch linux-block 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 22 repliesIn review
  2. v33 patches 11 repliesSuperseded
  3. v13 patches 1 replySuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3blk-mq: Return true if request was completedblock/blk-mq.c include/linux/blk-mq.h+4 -31 reply
2/3scsi: Do not rely on blk-mq for double completionsdrivers/scsi/scsi_error.c drivers/scsi/scsi_lib.c include/scsi/scsi_cmnd.h+27 -121 reply
3/3blk-mq: Simplify request completion stateblock/blk-mq.c include/linux/blk-mq.h+1 -171 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCHv4 0/3] scsi timeout handling updates

The iterative update to the previous version taking into account review comments.

Background:

The main objective is to remove the generic block layer's lock prefix currently required to transition a request to its completed state by shifting that expense to lower level drivers that actually need it, and removing the software layering violation that was required to use that mechnaism.

Changes since v3:

The complete state is moved to its own field separate from the non-atomic scsi_cmnd "flags" field.

Code comments added to describe the more obscure handling for fake timeout injection.

Keith Busch (3):
blk-mq: Return true if request was completed
scsi: Do not rely on blk-mq for double completions
blk-mq: Simplify request completion state

 block/blk-mq.c            |  9 ++++-----
 drivers/scsi/scsi_error.c | 22 +++++++++++-----------
 drivers/scsi/scsi_lib.c   | 13 ++++++++++++-
 include/linux/blk-mq.h    | 16 +---------------
 include/scsi/scsi_cmnd.h  |  4 ++++
 5 files changed, 32 insertions(+), 32 deletions(-)
Signature · 1 line
2.14.4