fanotify: add support for more event types
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest17 patches 13 repliesIn review
- v415 patches 38 repliesSuperseded
- v313 patches 28 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 9 patches | 2 replies | Superseded |
Changes in v5 from the cover letter
- Rebase on v5.0-rc1
- Address style review comments on v4
- info_len includes padding to info_hdr alignment
- handle caching of fsid correctly when inotify marks on object exist
- Report dirent events on subdirs only with FAN_ONDIR
- Report XXX_SELF events on directories only with FAN_ONDIR
- Do not merge dirent events on subdirs with dirent events on non subdirs
[1] https://github.com/amir73il/linux/commits/fanotify_dirent-v5
[2] https://github.com/amir73il/ltp/commits/fanotify_fid
[3] https://github.com/amir73il/ltp/commits/fanotify_dirent
[4] https://github.com/amir73il/inotify-tools/commits/fanotify_dirent
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | fsnotify: annotate directory entry modification eventsinclude/ | +59 | 1 reply | |
| 2/17 | fsnotify: remove dirent events from FS_EVENTS_POSS_ON_CHILD maskinclude/ | +21 | 0 replies | |
| 3/17 | fsnotify: send all event types to super block marksfs/ | +7 | 0 replies | |
| 4/17 | fsnotify: move mask out of struct fsnotify_eventfs/ fs/ fs/ +5 more | +29 | 0 replies | |
| 5/17 | fanotify: rename struct fanotify_{,perm_}event_infofs/ fs/ fs/ | +26 | 0 replies | |
| 6/17 | fanotify: open code fill_event_metadata()fs/ | +26 | 0 replies | |
| 7/17 | fanotify: encode file identifier for FAN_REPORT_FIDfs/ fs/ fs/ +1 more | +153 | 2 replies | |
| 8/17 | fanotify: copy event fid info to userfs/ fs/ include/ | +102 | 1 reply | |
| 9/17 | fanotify: enable FAN_REPORT_FID init flagfs/ include/ | +61 | 0 replies | |
| 10/17 | fanotify: cache fsid in fsnotify_mark_connectorfs/ fs/ fs/ +2 more | +135 | 5 replies | |
| 11/17 | vfs: add vfs_get_fsid() helperfs/ include/ | +17 | 0 replies | |
| 12/17 | fanotify: use vfs_get_fsid() helper instead of vfs_statfs()fs/ | +10 | 0 replies | |
| 13/17 | fsnotify: report FS_ISDIR flag with MOVE_SELF and DELETE_SELF eventsfs/ include/ | +28 | 1 reply | |
| 14/17 | fanotify: check FS_ISDIR flag instead of d_is_dir()fs/ include/ | +4 | 0 replies | |
| 15/17 | fanotify: support events with data type FSNOTIFY_EVENT_INODEfs/ fs/ fs/ | +48 | 2 replies | |
| 16/17 | fanotify: add support for create/attrib/move/delete eventsfs/ fs/ include/ +1 more | +48 | 0 replies | |
| 17/17 | fanotify: report FAN_ONDIR to listener with FAN_REPORT_FIDfs/ include/ | +32 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 00/17] fanotify: add support for more event types
Jan,
This is the 5th revision of patch series to add support for filesystem change monitoring to fanotify.
The complete work is available on fanotify_dirent-v5 branch [1] on github.
LTP tests by Matthew Bobrowski for FAN_REPORT_FID are available on my LTP branch fanotify_fid [2]. A WIP test for dirent events is available on my LTP branch fanotify_dirent [3].
Matthew Bobrowski is working on a proper test for dirent events and on man pages for both FAN_REPORT_FID and dirent events (Thanks!).
The combined functionality of FAN_MARK_FILESYSTEM, FAN_REPORT_FID and dirent modification events is demonstrated with a prototype of global filesystem monitor based on inotify-tools [4].
Thanks,
Amir.
Changes since v4:
- Rebase on v5.0-rc1
- Address style review comments on v4
- info_len includes padding to info_hdr alignment
- handle caching of fsid correctly when inotify marks on object exist
- Report dirent events on subdirs only with FAN_ONDIR
- Report XXX_SELF events on directories only with FAN_ONDIR
- Do not merge dirent events on subdirs with dirent events on non subdirs
[1] https://github.com/amir73il/linux/commits/fanotify_dirent-v5
[2] https://github.com/amir73il/ltp/commits/fanotify_fid
[3] https://github.com/amir73il/ltp/commits/fanotify_dirent
[4] https://github.com/amir73il/inotify-tools/commits/fanotify_dirent
Amir Goldstein (17):
fsnotify: annotate directory entry modification events
fsnotify: remove dirent events from FS_EVENTS_POSS_ON_CHILD mask
fsnotify: send all event types to super block marks
fsnotify: move mask out of struct fsnotify_event
fanotify: rename struct fanotify_{,perm_}event_info
fanotify: open code fill_event_metadata()
fanotify: encode file identifier for FAN_REPORT_FID
fanotify: copy event fid info to user
fanotify: enable FAN_REPORT_FID init flag
fanotify: cache fsid in fsnotify_mark_connector
vfs: add vfs_get_fsid() helper
fanotify: use vfs_get_fsid() helper instead of vfs_statfs()
fsnotify: report FS_ISDIR flag with MOVE_SELF and DELETE_SELF events
fanotify: check FS_ISDIR flag instead of d_is_dir()
fanotify: support events with data type FSNOTIFY_EVENT_INODE
fanotify: add support for create/attrib/move/delete events
fanotify: report FAN_ONDIR to listener with FAN_REPORT_FID
fs/notify/fanotify/fanotify.c | 229 +++++++++++++++++---- fs/notify/fanotify/fanotify.h | 105 ++++++++-- fs/notify/fanotify/fanotify_user.c | 288 +++++++++++++++++++-------- fs/notify/fsnotify.c | 15 +- fs/notify/inotify/inotify.h | 1 + fs/notify/inotify/inotify_fsnotify.c | 18 +- fs/notify/inotify/inotify_user.c | 5 +- fs/notify/mark.c | 47 ++++- fs/notify/notification.c | 22 +- fs/statfs.c | 14 ++ include/linux/fanotify.h | 26 ++- include/linux/fsnotify.h | 94 +++++++-- include/linux/fsnotify_backend.h | 70 ++++--- include/linux/statfs.h | 3 + include/uapi/linux/fanotify.h | 29 +++ 15 files changed, 753 insertions(+), 213 deletions(-)
Signature · 1 line
2.17.1