Skip to content

misc cleanups

Stephen Hemminger netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22lib/ll_addr: whitespace and indent cleanuplib/ll_addr.c+13 -110 replies
2/22lib/utils: make local functions staticinclude/utils.h lib/utils.c+7 -460 replies
3/22lib/color: make local functions staticinclude/color.h lib/color.c+4 -40 replies
4/22lib/ll_map: make local function staticinclude/ll_map.h lib/ll_map.c+1 -20 replies
5/22libnetlnk: unused and local functions cleanupinclude/libnetlink.h lib/libnetlink.c+2 -330 replies
6/22genl: remove dead codegenl/ctrl.c genl/genl_utils.h+0 -730 replies
7/22bridge: make local variables staticbridge/bridge.c bridge/monitor.c+3 -40 replies
8/22ip: make flag names const/staticip/ipaddress.c+1 -10 replies
9/22ipmonitor: make local variable staticip/ipmonitor.c+1 -10 replies
10/22ipxfrm: make local functions staticip/ipxfrm.c ip/xfrm.h ip/xfrm_monitor.c+7 -150 replies
11/22tc: drop unused name_to_id functioninclude/names.h lib/names.c+0 -290 replies
12/22tipc: make cmd_find statictipc/cmdl.c tipc/cmdl.h+1 -30 replies
13/22tc/class: make filter variables statictc/tc_class.c+3 -30 replies
14/22tc/police: make print_police statictc/m_police.c tc/tc_util.h+7 -60 replies
15/22ss: make local variables staticmisc/ss.c+14 -140 replies
16/22tc/pedit: make functions statictc/m_pedit.c tc/m_pedit.h+14 -340 replies
17/22tc/ematch: make local functions statictc/m_ematch.c tc/m_ematch.h+3 -280 replies
18/22tc/util: make local functions statictc/tc_util.c tc/tc_util.h+3 -190 replies
19/22tc/meta: make meta_table static and consttc/em_meta.c+6 -60 replies
20/22tc/action: make variables statictc/m_action.c+2 -20 replies
21/22tc/pedit: use structure initializationtc/p_eth.c tc/p_icmp.c tc/p_ip.c +3 more+12 -180 replies
22/22rdma: make local functions staticrdma/rdma.h rdma/utils.c+6 -171 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH iproute2 00/22] misc cleanups

Code cleanup including:
* make local functions static
* drop dead code
* whitespace code style cleanup

Stephen Hemminger (22):
lib/ll_addr: whitespace and indent cleanup
lib/utils: make local functions static
lib/color: make local functions static
lib/ll_map: make local function static
libnetlnk: unused and local functions cleanup
genl: remove dead code
bridge: make local variables static
ip: make flag names const/static
ipmonitor: make local variable static
ipxfrm: make local functions static
tc: drop unused name_to_id function
tipc: make cmd_find static
tc/class: make filter variables static
tc/police: make print_police static
ss: make local variables static
tc/pedit: make functions static
tc/ematch: make local functions static
tc/util: make local functions static
tc/meta: make meta_table static and const
tc/action: make variables static
tc/pedit: use structure initialization
rdma: make local functions static

 bridge/bridge.c      |  5 ++--
 bridge/monitor.c     |  2 +-
 genl/ctrl.c          | 71 --------------------------------------------
 genl/genl_utils.h    |  2 --
 include/color.h      |  2 --
 include/libnetlink.h |  7 -----
 include/ll_map.h     |  1 -
 include/names.h      |  1 -
 include/utils.h      |  5 ----
 ip/ipaddress.c       |  2 +-
 ip/ipmonitor.c       |  2 +-
 ip/ipxfrm.c          | 11 +++----
 ip/xfrm.h            |  9 ------
 ip/xfrm_monitor.c    |  2 +-
 lib/color.c          |  6 ++--
 lib/libnetlink.c     | 28 ++---------------
 lib/ll_addr.c        | 24 ++++++++-------
 lib/ll_map.c         |  2 +-
 lib/names.c          | 28 -----------------
 lib/utils.c          | 48 +++++-------------------------
 misc/ss.c            | 28 ++++++++---------
 rdma/rdma.h          | 11 -------
 rdma/utils.c         | 12 ++++----
 tc/em_meta.c         | 12 ++++----
 tc/m_action.c        |  4 +--
 tc/m_ematch.c        | 30 ++-----------------
 tc/m_ematch.h        |  1 -
 tc/m_pedit.c         | 33 +++++++++-----------
 tc/m_pedit.h         | 15 ----------
 tc/m_police.c        | 10 +++++--
 tc/p_eth.c           |  5 ++--
 tc/p_icmp.c          |  5 ++--
 tc/p_ip.c            |  5 ++--
 tc/p_ip6.c           |  5 ++--
 tc/p_tcp.c           |  5 ++--
 tc/p_udp.c           |  5 ++--
 tc/tc_class.c        |  6 ++--
 tc/tc_util.c         | 17 ++---------
 tc/tc_util.h         |  8 -----
 tipc/cmdl.c          |  2 +-
 tipc/cmdl.h          |  2 --
 41 files changed, 110 insertions(+), 369 deletions(-)
Signature · 1 line
2.17.1