Skip to content

add flow_rule infrastructure

Pablo Neira Ayuso netdev netfilter-devel 7 versions – Applied

Status from this message: Applied to net-next, let's see where this goes.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest12 patches 7 repliesApplied
  2. v612 patches 15 repliesSuperseded
  3. v512 patches 19 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v412 patches7 repliesSuperseded
v312 patches14 repliesSuperseded
v212 patches31 repliesSuperseded
v110 patches7 repliesSuperseded

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/12flow_offload: add flow_rule and flow_match structures and use themdrivers/net/ethernet/broadcom/bnxt/bnxt_tc.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c drivers/net/ethernet/intel/i40e/i40e_main.c +14 more+1209 -12221 reply
2/12net/mlx5e: support for two independent packet edit actionsdrivers/net/ethernet/mellanox/mlx5/core/en_tc.c+59 -223 replies
3/12flow_offload: add flow action infrastructureinclude/net/flow_offload.h include/net/pkt_cls.h net/core/flow_offload.c +2 more+102 -60 replies
4/12cls_api: add translator to flow_action representationinclude/net/pkt_cls.h net/sched/cls_api.c net/sched/cls_flower.c+115 -00 replies
5/12flow_offload: add statistics retrieval infrastructure and use itdrivers/net/ethernet/broadcom/bnxt/bnxt_tc.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +5 more+28 -100 replies
6/12drivers: net: use flow action infrastructuredrivers/net/ethernet/broadcom/bnxt/bnxt_tc.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +4 more+418 -4261 reply
7/12cls_flower: don't expose TC actions to drivers anymoreinclude/net/pkt_cls.h net/sched/cls_flower.c+0 -60 replies
8/12flow_offload: add wake-up-on-lan and queue to flow_actioninclude/net/flow_offload.h+7 -00 replies
9/12ethtool: add ethtool_rx_flow_spec to flow_rule structure translatorinclude/linux/ethtool.h net/core/ethtool.c+256 -00 replies
10/12dsa: bcm_sf2: use flow_rule infrastructuredrivers/net/dsa/bcm_sf2_cfp.c+67 -350 replies
11/12qede: place ethtool_rx_flow_spec after code after TC flower codebasedrivers/net/ethernet/qlogic/qede/qede_filter.c+132 -1320 replies
12/12qede: use ethtool_rx_flow_rule() to remove duplicated parser codedrivers/net/ethernet/qlogic/qede/qede_filter.c+76 -2030 replies

Reviews trailers per patch

11 of 12 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoSaeed MahameedFlorian Fainelli
1/12A-b
2/12A-b A-b
3/12A-b
4/12A-b
5/12A-b
6/12A-b
7/12A-b
8/12A-b
9/12A-b
10/12A-b R-b
11/12A-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH 00/12 net-next,v7] add flow_rule infrastructure

Hi,

This patchset, as is, allows us to reuse the driver codebase to configure ACL hardware offloads for the ethtool_rxnfc and the TC flower interfaces. A few clients for this infrastructure are presented, such as the bcm_sf2 and the qede drivers, for reference. Moreover all of the existing drivers in the tree are converted to use this infrastructure.

This patchset is re-using the existing flow dissector infrastructure that was introduced by Jiri Pirko et al. so the amount of abstractions that this patchset adds are minimal. Well, just a few wrapper structures for the selector side of the rules. And, in order to express actions, this patchset exposes an action API that is based on the existing TC action infrastructure and what existing drivers already support on that front.

v7: This patchset is a rebase on top of the net-next tree, after
addressing questions and feedback from driver developers in the last batch.

Please, apply. Thanks!

P.S: I would like to thank driver developers for their fruitful
cooperation and feedback, which has been very useful to shape the layout of this incremental work on top of the existing infrastructure. Thanks!

Pablo Neira Ayuso (12):
flow_offload: add flow_rule and flow_match structures and use them net/mlx5e: support for two independent packet edit actions
flow_offload: add flow action infrastructure
cls_api: add translator to flow_action representation
flow_offload: add statistics retrieval infrastructure and use it
drivers: net: use flow action infrastructure
cls_flower: don't expose TC actions to drivers anymore
flow_offload: add wake-up-on-lan and queue to flow_action
ethtool: add ethtool_rx_flow_spec to flow_rule structure translator
dsa: bcm_sf2: use flow_rule infrastructure
qede: place ethtool_rx_flow_spec after code after TC flower codebase
qede: use ethtool_rx_flow_rule() to remove duplicated parser code

 drivers/net/dsa/bcm_sf2_cfp.c                      | 102 +--
 drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c       | 252 ++++----
 .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c   | 450 ++++++-------
 drivers/net/ethernet/intel/i40e/i40e_main.c        | 178 ++----
 drivers/net/ethernet/intel/iavf/iavf_main.c        | 195 +++---
 drivers/net/ethernet/intel/igb/igb_main.c          |  64 +-
 .../net/ethernet/mellanox/mlx5/core/en/tc_tun.c    |  68 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c    | 698 ++++++++++-----------
 drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c |   2 +-
 .../net/ethernet/mellanox/mlxsw/spectrum_flower.c  | 258 ++++----
 drivers/net/ethernet/netronome/nfp/flower/action.c | 198 +++---
 drivers/net/ethernet/netronome/nfp/flower/match.c  | 417 ++++++------
 .../net/ethernet/netronome/nfp/flower/offload.c    | 154 ++---
 drivers/net/ethernet/qlogic/qede/qede_filter.c     | 572 +++++++----------
 include/linux/ethtool.h                            |  15 +
 include/net/flow_offload.h                         | 203 ++++++
 include/net/pkt_cls.h                              |  16 +-
 net/core/Makefile                                  |   2 +-
 net/core/ethtool.c                                 | 241 +++++++
 net/core/flow_offload.c                            | 153 +++++
 net/sched/cls_api.c                                | 116 ++++
 net/sched/cls_flower.c                             |  71 ++-
 22 files changed, 2416 insertions(+), 2009 deletions(-)
 create mode 100644 include/net/flow_offload.h
 create mode 100644 net/core/flow_offload.c
Signature · 1 line
2.11.0