Misc fixes to NBD
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 41 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | nbd: fix whitespace in server error messagenbd/ | +1 | 2 replies | |
| 2/6 | nbd: stop waiting for a NBD response with NBD_CMD_DISCblock/ | +1 | 5 replies | |
| 3/6 | tests: pull qemu-nbd iotest helpers into common.nbd filetests/ tests/ | +64 | 6 replies | |
| 4/6 | tests: check if qemu-nbd is still alive before waitingtests/ | +9 | 2 replies | |
| 5/6 | tests: add iotests helpers for dealing with TLS certificatestests/ | +139 | 5 replies | |
| 6/6 | tests: exercise NBD server in TLS modetests/ tests/ tests/ +1 more | +180 | 21 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Daniel P. Berrangé | Philippe Mathieu-Daudé |
|---|---|---|---|
| 1/6 | R-b | R-b | |
| 2/6 | R-b | ||
| 3/6 | R-b | ||
| 4/6 | R-b | ||
| 5/6 | |||
| 6/6 | R-b T-b | R-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH 0/6] Misc fixes to NBD
This does two minor fixes to the NBD code and adds significant coverage of the NBD TLS support to detect future problems.
The first two patches should be for 3.1.
The tests can wait till 4.0 if desired.
Daniel P. Berrangé (6):
nbd: fix whitespace in server error message
nbd: stop waiting for a NBD response with NBD_CMD_DISC
tests: pull qemu-nbd iotest helpers into common.nbd file
tests: check if qemu-nbd is still alive before waiting
tests: add iotests helpers for dealing with TLS certificates
tests: exercise NBD server in TLS mode
block/nbd-client.c | 1 + nbd/server.c | 2 +- tests/qemu-iotests/058 | 47 ++---------- tests/qemu-iotests/233 | 99 ++++++++++++++++++++++++ tests/qemu-iotests/233.out | 33 ++++++++ tests/qemu-iotests/common.nbd | 111 +++++++++++++++++++++++++++ tests/qemu-iotests/common.tls | 139 ++++++++++++++++++++++++++++++++++ tests/qemu-iotests/group | 1 + 8 files changed, 393 insertions(+), 40 deletions(-) create mode 100755 tests/qemu-iotests/233 create mode 100644 tests/qemu-iotests/233.out create mode 100644 tests/qemu-iotests/common.nbd create mode 100644 tests/qemu-iotests/common.tls
Signature · 1 line
2.19.1