Skip to content

Mark clocks as critical for MT6797

[email protected] linux-arm-kernel linux-clk linux-mediatek lkml 3 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 6 repliesApplied
  2. v33 patches 2 repliesSuperseded
  3. v23 patches 7 repliesSuperseded

Changes in v4 from the cover letter

- add comments explaining why the clock muxer and gates are marked as critical

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3clk: mediatek: Add MUX_FLAGS macrodrivers/clk/mediatek/clk-mtk.h+6 -21 reply
2/3clk: mediatek: Add flags to mtk_gatedrivers/clk/mediatek/clk-gate.c drivers/clk/mediatek/clk-gate.h drivers/clk/mediatek/clk-mtk.c +1 more+7 -31 reply
3/3clk: mediatek: Mark bus and DRAM related clocks as criticaldrivers/clk/mediatek/clk-mt6797.c+43 -252 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMars Cheng
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] Mark clocks as critical for MT6797

From: Matthias Brugger <[email protected]>

Jasper send this series some month ago. As there was no reaction from his side, I'll do a friendly take-over.
I tested the patches on my Helios X20 boards and they fix the issue. I didn't add a Tested-by tag as I added my Signed-off-by.

Changes since v3:
- add comments explaining why the clock muxer and gates are marked as critical

Changes since v2 (https://patchwork.kernel.org/patch/10686759/):
- axi_sel is not needed, drop CLK_IS_CRITICAL for it.
- update commit message
- add Acked-by from Mars

Changes since v1:
- add a fixes tag.

---

Currently, DRAM-related clocks and the axi_sel MUX are not marked with CLK_IS_CRITICAL for MT6797. This causes memory corruption when the system is booted without clk_ignore_unused.

This patchset

1. Makes it possible to mark outputs of MUXes as critical by introducing a new macro, MUX_FLAGS,
2. Makes it possible to mark gates as critical by adding flags to mtk_gate, and
3. Marks axi_sel, ddrphycfg_sel, infra_dramc_f26m and infra_dramc_b_f26m as critical.

The addition of flags to mtk_gate also exists in the patch series "Add basic and clock support for Mediatek MT8183 SoC" [1]. The type of flags is unsigned int in that series, but the real type is unsigned long, so my patch differs from that patch.

[1] https://patchwork.kernel.org/patch/10549953/

Jasper Mattsson (3):
clk: mediatek: Add MUX_FLAGS macro
clk: mediatek: Add flags to mtk_gate
clk: mediatek: Mark bus and DRAM related clocks as critical

 drivers/clk/mediatek/clk-gate.c   |  4 +-
 drivers/clk/mediatek/clk-gate.h   |  3 +-
 drivers/clk/mediatek/clk-mt6797.c | 68 +++++++++++++++++++------------
 drivers/clk/mediatek/clk-mtk.c    |  2 +-
 drivers/clk/mediatek/clk-mtk.h    |  9 +++-
 5 files changed, 56 insertions(+), 30 deletions(-)
Signature · 1 line
2.20.1