Skip to content

perf top: Rework processing code

Jiri Olsa lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12perf tools: Fix build on sparctools/perf/bench/epoll-ctl.c tools/perf/bench/epoll-wait.c+8 -50 replies
2/12perf tools: Rework show_progress for __ordered_events__flushtools/perf/util/ordered-events.c+5 -30 replies
3/12perf tools: Add private data to struct ordered_eventstools/perf/util/ordered-events.c tools/perf/util/ordered-events.h tools/perf/util/session.c+9 -40 replies
4/12perf top: Save and display the lost count statstools/perf/builtin-top.c tools/perf/ui/browsers/hists.c tools/perf/util/top.c +1 more+35 -40 replies
5/12perf top: Moving lost events warning to helplinetools/perf/builtin-top.c+5 -116 replies
6/12perf top: Add processing threadtools/perf/builtin-top.c tools/perf/util/ordered-events.c tools/perf/util/ordered-events.h +1 more+151 -620 replies
7/12perf top: Use cond variable instead of the locktools/perf/builtin-top.c tools/perf/util/top.h+20 -80 replies
8/12perf top: Set session_done when exitingtools/perf/builtin-top.c+9 -30 replies
9/12perf top: Drop samples which are behind more than refresh ratetools/perf/builtin-top.c+22 -30 replies
10/12perf top: Save and display the drop count statstools/perf/builtin-top.c tools/perf/ui/browsers/hists.c tools/perf/util/top.c +1 more+13 -50 replies
11/12perf top: Display slow reader warning for when droping samplestools/perf/builtin-top.c+1 -10 replies
12/12perf top: Move perf_top__reset_sample_counters after counts displaytools/perf/builtin-top.c tools/perf/ui/browsers/hists.c tools/perf/util/top.c+4 -40 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid S. MillerNamhyung Kim
SeriesA-b A-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] perf top: Rework processing code

hi,
David reported issues with perf top loosing side band events so we moved mmap reading and hists processing into separated threads.

This patchset also adds dropping sample logic when the processing falls behind the reader thread. This way we get incomplete but current data in perf top.

Also available in:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/fixes

thanks,
jirka

---
David Miller (1):
perf tools: Fix build on sparc

Jiri Olsa (11):
perf tools: Rework show_progress for __ordered_events__flush perf tools: Add private data to struct ordered_events perf top: Save and display the lost count stats
perf top: Moving lost events warning to helpline
perf top: Add processing thread
perf top: Use cond variable instead of the lock
perf top: Set session_done when exiting
perf top: Drop samples which are behind more than refresh rate perf top: Save and display the drop count stats
perf top: Display slow reader warning for when droping samples perf top: Move perf_top__reset_sample_counters after counts display

 tools/perf/bench/epoll-ctl.c     |   7 +--
 tools/perf/bench/epoll-wait.c    |   6 ++-
 tools/perf/builtin-top.c         | 281 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------
 tools/perf/ui/browsers/hists.c   |  11 +++++
 tools/perf/util/ordered-events.c |  16 ++++---
 tools/perf/util/ordered-events.h |   5 ++-
 tools/perf/util/session.c        |   3 +-
 tools/perf/util/top.c            |   8 ++--
 tools/perf/util/top.h            |  10 ++++-
 9 files changed, 258 insertions(+), 89 deletions(-)