target: user configurable T10 Vendor ID
Status from this message: Applied to 4.21/scsi-queue, thank you!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest5 patches 5 repliesApplied
- v65 patches 7 repliesSuperseded
- v55 patches 9 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 7 patches | 27 replies | Superseded | |
| v3 | 4 patches | 13 replies | Superseded |
Changes in v7 from the cover letter
- PATCH 2/5
+ fill pscsi inquiry data using proper sd->inquiry pointer names
+ dump pscsi sd->inquiry data using sprintf
+ tweak emulate_model_alias truncation warning
+ drop a few duplicate BUILD_BUG_ON()s
+ drop Hannes' sign-off
- PATCH 3/5
+ check user vendor string for non-ascii-printable chars
+ strip newline before INQUIRY_VENDOR_LEN length check
+ drop sign-offs from Bryant, Lee and Hannes
Patches in v7 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | target: use consistent left-aligned ASCII INQUIRY datadrivers/ | +12 | 0 replies | |
| 2/5 | target: consistently null-terminate t10_wwn stringsdrivers/ drivers/ drivers/ +3 more | +63 | 1 reply | |
| 3/5 | target: add device vendor_id configfs attributedrivers/ | +70 | 3 replies | |
| 4/5 | target: remove hardcoded T10 Vendor ID in INQUIRY responsedrivers/ | +5 | 0 replies | |
| 5/5 | target: perform t10_wwn ID initialisation in target_alloc_device()drivers/ | +7 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Bryant G. Ly | Lee Duncan | Hannes Reinecke | Roman Bolshakov |
|---|---|---|---|---|---|
| 1/5 | R-b | R-b | R-b | R-b | R-b |
| 2/5 | R-b | ||||
| 3/5 | R-b | ||||
| 4/5 | R-b | R-b | R-b | R-b | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v7 0/5] target: user configurable T10 Vendor ID
This patch-set allows for the modification of the T10 Vendor Identification string returned in the SCSI INQUIRY response, via the target/core/$backstore/$name/wwn/vendor_id ConfigFS path.
Changes since v6:
- PATCH 2/5
+ fill pscsi inquiry data using proper sd->inquiry pointer names
+ dump pscsi sd->inquiry data using sprintf
+ tweak emulate_model_alias truncation warning
+ drop a few duplicate BUILD_BUG_ON()s
+ drop Hannes' sign-off
- PATCH 3/5
+ check user vendor string for non-ascii-printable chars
+ strip newline before INQUIRY_VENDOR_LEN length check
+ drop sign-offs from Bryant, Lee and Hannes
Changes since v5:
- remove unnecessary TRANSPORT_FLAG_PASSTHROUGH conditional from t10_wwn ID defaults initialisation.
Changes since v4:
- merge null-termination changes into a single patch
- add patch to initialise t10_wwn ID defaults earlier
- use strlcpy() instead of strncpy() in some places
Changes since v3:
- perform explicit null termination of t10_wwn vendor, model and revision fields.
- replace field dump for-loops
Changes since v2:
- https://www.spinics.net/lists/target-devel/msg10720.html
- Support eight byte vendor ID strings
- Split out consistent INQUIRY data padding as a separate patch
- Drop t10_wwn.model buffer print fix, already upstream
Changes since v1:
- https://www.spinics.net/lists/target-devel/msg10545.html
- Rebase against nab's for-next branch, which includes Christoph's configfs API changes.
David Disseldorp (5):
target: use consistent left-aligned ASCII INQUIRY data
target: consistently null-terminate t10_wwn strings
target: add device vendor_id configfs attribute
target: remove hardcoded T10 Vendor ID in INQUIRY response
target: perform t10_wwn ID initialisation in target_alloc_device()
drivers/target/target_core_configfs.c | 86 +++++++++++++++++++++++++-- drivers/target/target_core_device.c | 55 +++++------------ drivers/target/target_core_pscsi.c | 50 +++++----------- drivers/target/target_core_spc.c | 20 +++++-- drivers/target/target_core_stat.c | 32 +++------- include/target/target_core_base.h | 14 ++++- 6 files changed, 145 insertions(+), 112 deletions(-)