Skip to content

mailbox: Device-managed registration

Thierry Reding lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest19 patches 1 replyIn review
  2. v219 patches 12 repliesSuperseded
  3. v119 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- fix the level of indirection in the device-managed pointer
- fix a build error in the OMAP mailbox driver

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19mailbox: Add device-managed registration functionsdrivers/mailbox/mailbox.c include/linux/mailbox_controller.h+75 -00 replies
2/19mailbox: arm-mhu: Use device-managed registration APIdrivers/mailbox/arm_mhu.c+1 -110 replies
3/19mailbox: bcm2835: Use device-managed registration APIdrivers/mailbox/bcm2835-mailbox.c+1 -90 replies
4/19mailbox: bcm-flexrm: Use device-managed registration APIdrivers/mailbox/bcm-flexrm-mailbox.c+1 -31 reply
5/19mailbox: bcm-pdc: Use device-managed registration APIdrivers/mailbox/bcm-pdc-mailbox.c+1 -30 replies
6/19mailbox: hi3660: Use device-managed registration APIdrivers/mailbox/hi3660-mailbox.c+1 -100 replies
7/19mailbox: hi6220: Use device-managed registration APIdrivers/mailbox/hi6220-mailbox.c+1 -100 replies
8/19mailbox: imx: Use device-managed registration APIdrivers/mailbox/imx-mailbox.c+1 -20 replies
9/19mailbox: altera: Use device-managed registration APIdrivers/mailbox/mailbox-altera.c+1 -140 replies
10/19mailbox: sti: Use device-managed registration APIdrivers/mailbox/mailbox-sti.c+1 -120 replies
11/19mailbox: xgene-slimpro: Use device-managed registration APIdrivers/mailbox/mailbox-xgene-slimpro.c+1 -100 replies
12/19mailbox: mtk-cmdq: Use device-managed registration APIdrivers/mailbox/mtk-cmdq-mailbox.c+1 -20 replies
13/19mailbox: mtk-cmdq: Remove needless devm_kfree() callsdrivers/mailbox/mtk-cmdq-mailbox.c+0 -80 replies
14/19mailbox: omap: Use device-managed registration APIdrivers/mailbox/omap-mailbox.c+1 -30 replies
15/19mailbox: platform-mhu: Use device-managed registration APIdrivers/mailbox/platform_mhu.c+1 -110 replies
16/19mailbox: qcom-apcs: Use device-managed registration APIdrivers/mailbox/qcom-apcs-ipc-mailbox.c+1 -20 replies
17/19mailbox: rockchip: Use device-managed registration APIdrivers/mailbox/rockchip-mailbox.c+1 -140 replies
18/19mailbox: stm32-ipcc: Use device-managed registration APIdrivers/mailbox/stm32-ipcc.c+1 -30 replies
19/19mailbox: ti-msgmgr: Use device-managed registration APIdrivers/mailbox/ti-msgmgr.c+1 -120 replies

Reviews trailers per patch

11 of 19 patches have a Reviewed-by or Acked-by.

PatchBjorn AnderssonSudeep HollaEric AnholtLeo YanOleksij RempelLudovic BarreCaesar WangNeil ArmstrongLee JonesScott Branden
1/19R-b R-b
2/19R-b
3/19R-b
4/19A-b
5/19
6/19T-b
7/19R-b
8/19R-b
9/19
10/19A-b
11/19
12/19
13/19
14/19
15/19A-b
16/19R-b
17/19R-b
18/19R-b
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/19] mailbox: Device-managed registration

From: Thierry Reding <[email protected]>

Hi,

This series of patches adds device-managed registration functions for mailbox controllers. A number of drivers can be simplified by making use of this new API both in the error cleanup paths in their probe functions and in the driver remove implementation.

In addition to adding the new API this series converts all drivers to use it. There is also an additional cleanup patch for the mtk-cmdq driver that removes some calls to devm_kfree() that are not needed.

Changes in v3:
- fix the level of indirection in the device-managed pointer
- fix a build error in the OMAP mailbox driver

Thierry

Thierry Reding (19):
mailbox: Add device-managed registration functions
mailbox: arm-mhu: Use device-managed registration API
mailbox: bcm2835: Use device-managed registration API
mailbox: bcm-flexrm: Use device-managed registration API
mailbox: bcm-pdc: Use device-managed registration API
mailbox: hi3660: Use device-managed registration API
mailbox: hi6220: Use device-managed registration API
mailbox: imx: Use device-managed registration API
mailbox: altera: Use device-managed registration API
mailbox: sti: Use device-managed registration API
mailbox: xgene-slimpro: Use device-managed registration API
mailbox: mtk-cmdq: Use device-managed registration API
mailbox: mtk-cmdq: Remove needless devm_kfree() calls
mailbox: omap: Use device-managed registration API
mailbox: platform-mhu: Use device-managed registration API
mailbox: qcom-apcs: Use device-managed registration API
mailbox: rockchip: Use device-managed registration API
mailbox: stm32-ipcc: Use device-managed registration API
mailbox: ti-msgmgr: Use device-managed registration API

 drivers/mailbox/arm_mhu.c               | 12 +----
 drivers/mailbox/bcm-flexrm-mailbox.c    |  4 +-
 drivers/mailbox/bcm-pdc-mailbox.c       |  4 +-
 drivers/mailbox/bcm2835-mailbox.c       | 10 +---
 drivers/mailbox/hi3660-mailbox.c        | 11 +---
 drivers/mailbox/hi6220-mailbox.c        | 11 +---
 drivers/mailbox/imx-mailbox.c           |  3 +-
 drivers/mailbox/mailbox-altera.c        | 15 +-----
 drivers/mailbox/mailbox-sti.c           | 13 +----
 drivers/mailbox/mailbox-xgene-slimpro.c | 11 +---
 drivers/mailbox/mailbox.c               | 70 +++++++++++++++++++++++++
 drivers/mailbox/mtk-cmdq-mailbox.c      | 11 +---
 drivers/mailbox/omap-mailbox.c          |  4 +-
 drivers/mailbox/platform_mhu.c          | 12 +----
 drivers/mailbox/qcom-apcs-ipc-mailbox.c |  3 +-
 drivers/mailbox/rockchip-mailbox.c      | 15 +-----
 drivers/mailbox/stm32-ipcc.c            |  4 +-
 drivers/mailbox/ti-msgmgr.c             | 13 +----
 include/linux/mailbox_controller.h      |  5 ++
 19 files changed, 92 insertions(+), 139 deletions(-)
Signature · 1 line
2.19.1