Skip to content

qcow2: encryption threads

Vladimir Sementsov-Ogievskiy qemu-devel 6 versions – Applied

Status from this message: Thanks, applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 3 repliesApplied
  2. v510 patches 13 repliesSuperseded
  3. v49 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v39 patches15 repliesSuperseded
v28 patches8 repliesSuperseded
v111 patches2 repliesSuperseded

Changes in v6 from the cover letter

- Rebase on master, so 02 changed to reflect changes in qcow2_compress(), keep r-b.
- Rewrite 06 to even simpler locking [Max], drop r-b
Drop following
"qcow2: qcow2_co_preadv: skip using hd_qiov when possible", I'll do it in my other coming soon series, and it is actually unrelated to current.
- Drop controversial perf test, hope I'll return to this topic, but not in context of these series.
- Add Max's r-b's to all here, except 06

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/8qcow2.h: add missing includeblock/qcow2-bitmap.c block/qcow2-cache.c block/qcow2-cluster.c +4 more+1 -60 replies
2/8qcow2: add separate file for threaded data processing functionsblock/Makefile.objs block/qcow2-threads.c block/qcow2.c +1 more+209 -1700 replies
3/8qcow2-threads: use thread_pool_submit_coblock/qcow2-threads.c+2 -150 replies
4/8qcow2-threads: qcow2_co_do_compress: protect queuing by mutexblock/qcow2-threads.c+7 -30 replies
5/8qcow2-threads: split out generic pathblock/qcow2-threads.c block/qcow2.c block/qcow2.h+34 -190 replies
6/8qcow2: qcow2_co_preadv: improve lockingblock/qcow2.c+2 -101 reply
7/8qcow2: bdrv_co_pwritev: move encryption code out of the lockblock/qcow2.c+21 -140 replies
8/8qcow2: do encryption in threadsblock/qcow2-cluster.c block/qcow2-threads.c block/qcow2.c +1 more+81 -210 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchAlberto GarciaPaolo BonziniMax Reitz
1/8R-b R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b R-b
5/8R-b R-b
6/8R-b
7/8R-b R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads

v6:
- Rebase on master, so 02 changed to reflect changes in qcow2_compress(), keep r-b.
- Rewrite 06 to even simpler locking [Max], drop r-b
Drop following
"qcow2: qcow2_co_preadv: skip using hd_qiov when possible", I'll do it in my other coming soon series, and it is actually unrelated to current.
- Drop controversial perf test, hope I'll return to this topic, but not in context of these series.
- Add Max's r-b's to all here, except 06

Vladimir Sementsov-Ogievskiy (8):
qcow2.h: add missing include
qcow2: add separate file for threaded data processing functions
qcow2-threads: use thread_pool_submit_co
qcow2-threads: qcow2_co_do_compress: protect queuing by mutex
qcow2-threads: split out generic path
qcow2: qcow2_co_preadv: improve locking
qcow2: bdrv_co_pwritev: move encryption code out of the lock
qcow2: do encryption in threads

 block/qcow2.h          |  20 ++-
 block/qcow2-bitmap.c   |   1 -
 block/qcow2-cache.c    |   1 -
 block/qcow2-cluster.c  |   8 +-
 block/qcow2-refcount.c |   1 -
 block/qcow2-snapshot.c |   1 -
 block/qcow2-threads.c  | 268 +++++++++++++++++++++++++++++++++++++++++
 block/qcow2.c          | 241 +++++-------------------------------
 block/Makefile.objs    |   2 +-
 9 files changed, 321 insertions(+), 222 deletions(-)
 create mode 100644 block/qcow2-threads.c
Signature · 1 line
2.18.0