qcow2: encryption threads
Status from this message: Thanks, applied to my block branch:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest8 patches 3 repliesApplied
- v510 patches 13 repliesSuperseded
- v49 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 9 patches | 15 replies | Superseded | |
| v2 | 8 patches | 8 replies | Superseded | |
| v1 | 11 patches | 2 replies | Superseded |
Changes in v6 from the cover letter
- Rebase on master, so 02 changed to reflect changes in qcow2_compress(), keep r-b.
- Rewrite 06 to even simpler locking [Max], drop r-b
Drop following
"qcow2: qcow2_co_preadv: skip using hd_qiov when possible", I'll do it in my other coming soon series, and it is actually unrelated to current.
- Drop controversial perf test, hope I'll return to this topic, but not in context of these series.
- Add Max's r-b's to all here, except 06
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | qcow2.h: add missing includeblock/ block/ block/ +4 more | +1 | 0 replies | |
| 2/8 | qcow2: add separate file for threaded data processing functionsblock/ block/ block/ +1 more | +209 | 0 replies | |
| 3/8 | qcow2-threads: use thread_pool_submit_coblock/ | +2 | 0 replies | |
| 4/8 | qcow2-threads: qcow2_co_do_compress: protect queuing by mutexblock/ | +7 | 0 replies | |
| 5/8 | qcow2-threads: split out generic pathblock/ block/ block/ | +34 | 0 replies | |
| 6/8 | qcow2: qcow2_co_preadv: improve lockingblock/ | +2 | 1 reply | |
| 7/8 | qcow2: bdrv_co_pwritev: move encryption code out of the lockblock/ | +21 | 0 replies | |
| 8/8 | qcow2: do encryption in threadsblock/ block/ block/ +1 more | +81 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Alberto Garcia | Paolo Bonzini | Max Reitz |
|---|---|---|---|
| 1/8 | R-b | R-b | |
| 2/8 | R-b | R-b | |
| 3/8 | R-b | R-b | |
| 4/8 | R-b | R-b | R-b |
| 5/8 | R-b | R-b | |
| 6/8 | R-b | ||
| 7/8 | R-b | R-b | |
| 8/8 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads
v6:
- Rebase on master, so 02 changed to reflect changes in qcow2_compress(), keep r-b.
- Rewrite 06 to even simpler locking [Max], drop r-b
Drop following
"qcow2: qcow2_co_preadv: skip using hd_qiov when possible", I'll do it in my other coming soon series, and it is actually unrelated to current.
- Drop controversial perf test, hope I'll return to this topic, but not in context of these series.
- Add Max's r-b's to all here, except 06
Vladimir Sementsov-Ogievskiy (8):
qcow2.h: add missing include
qcow2: add separate file for threaded data processing functions
qcow2-threads: use thread_pool_submit_co
qcow2-threads: qcow2_co_do_compress: protect queuing by mutex
qcow2-threads: split out generic path
qcow2: qcow2_co_preadv: improve locking
qcow2: bdrv_co_pwritev: move encryption code out of the lock
qcow2: do encryption in threads
block/qcow2.h | 20 ++- block/qcow2-bitmap.c | 1 - block/qcow2-cache.c | 1 - block/qcow2-cluster.c | 8 +- block/qcow2-refcount.c | 1 - block/qcow2-snapshot.c | 1 - block/qcow2-threads.c | 268 +++++++++++++++++++++++++++++++++++++++++ block/qcow2.c | 241 +++++------------------------------- block/Makefile.objs | 2 +- 9 files changed, 321 insertions(+), 222 deletions(-) create mode 100644 block/qcow2-threads.c
Signature · 1 line
2.18.0