Skip to content

target: drop unneeded pi_prot_format and get_fabric_name()

David Disseldorp target-devel 1 version Applied

Status from this message: Applied to 4.21/scsi-queue. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3target: drop unused pi_prot_format attribute storagedrivers/target/target_core_configfs.c include/target/target_core_base.h+1 -31 reply
2/3target: drop unnecessary get_fabric_name() accessor from fabric_opsdrivers/infiniband/ulp/srpt/ib_srpt.c drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c drivers/scsi/qla2xxx/tcm_qla2xxx.c +19 more+108 -1641 reply
3/3target: replace fabric_ops.name with fabric_aliasdrivers/infiniband/ulp/srpt/ib_srpt.c drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c drivers/scsi/qla2xxx/tcm_qla2xxx.c +9 more+28 -261 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] target: drop unneeded pi_prot_format and get_fabric_name()

This patchset removes unneeded se_dev_attrib.pi_prot_format and fabric_ops.get_fabric_name() struct members. Removal of the latter allowed for further cleanup due to the fact that all fabric modules except iscsi_target_mod provide matching strings for fabric_ops.name and fabric_ops.get_fabric_name() - use a new fabric_ops.fabric_alias member to handle the iscsi_target_mod special case.

Cheers, David

David Disseldorp (3):
target: drop unused pi_prot_format attribute storage
target: drop unnecessary get_fabric_name() accessor from fabric_ops
target: replace fabric_ops.name with fabric_alias

 drivers/infiniband/ulp/srpt/ib_srpt.c        |  8 +-
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c     |  8 +-
 drivers/scsi/qla2xxx/tcm_qla2xxx.c           | 16 +---
 drivers/target/iscsi/iscsi_target_configfs.c |  9 +-
 drivers/target/loopback/tcm_loop.c           |  8 +-
 drivers/target/sbp/sbp_target.c              |  8 +-
 drivers/target/target_core_alua.c            |  6 +-
 drivers/target/target_core_configfs.c        | 47 ++++++-----
 drivers/target/target_core_device.c          | 26 +++---
 drivers/target/target_core_fabric_configfs.c |  2 +-
 drivers/target/target_core_pr.c              | 88 ++++++++++----------
 drivers/target/target_core_stat.c            |  4 +-
 drivers/target/target_core_tmr.c             |  4 +-
 drivers/target/target_core_tpg.c             | 22 ++---
 drivers/target/target_core_transport.c       | 10 +--
 drivers/target/target_core_ua.c              |  4 +-
 drivers/target/target_core_xcopy.c           |  7 +-
 drivers/target/tcm_fc/tfc_conf.c             |  8 +-
 drivers/usb/gadget/function/f_tcm.c          |  8 +-
 drivers/vhost/scsi.c                         |  8 +-
 drivers/xen/xen-scsiback.c                   |  8 +-
 include/target/target_core_base.h            |  1 -
 include/target/target_core_fabric.h          | 14 +++-
 23 files changed, 134 insertions(+), 190 deletions(-)