Skip to content

block: Fix crash on migration with explicit child nodes

Kevin Wolf qemu-devel 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Checking whether there are still active parents only really works with a single pass, so that's what we do now [Max]
- Test case polishing [Max]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2block: Don't inactivate children before parentsblock.c+53 -310 replies
2/2iotests: Test migration with -blockdevtests/qemu-iotests/234 tests/qemu-iotests/234.out tests/qemu-iotests/group+152 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMax Reitz
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH for-3.1 v3 0/2] block: Fix crash on migration with explicit child nodes

v3:
- Checking whether there are still active parents only really works with a single pass, so that's what we do now [Max]
- Test case polishing [Max]

v2:
- Cover children that were created after their parents [Max]

Kevin Wolf (2):
block: Don't inactivate children before parents
iotests: Test migration with -blockdev

 block.c                    |  84 +++++++++++++++----------
 tests/qemu-iotests/234     | 121 +++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/234.out |  30 +++++++++
 tests/qemu-iotests/group   |   1 +
 4 files changed, 205 insertions(+), 31 deletions(-)
 create mode 100755 tests/qemu-iotests/234
 create mode 100644 tests/qemu-iotests/234.out
Signature · 1 line
2.19.1