block plugging improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest0 of 8 patches 0 repliesNew
- v18 patches 33 repliesSuperseded
Changes in v2 from the cover letter
- Fold the plug case for blk-mq, do it if we have 1 hw queue, or if we have ->commit_rqs().
- Add disable/enable IRQ to ataflop
- Drop nvme ring index helper
- Rework when to sort patch
Patches in v2 No applies recorded yet
None of the 8 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Omar Sandoval | Ming Lei | Christoph Hellwig | Michael S. Tsirkin | Sagi Grimberg |
|---|---|---|---|---|---|
| Series | R-b R-b R-b R-b | R-b R-b R-b R-b | R-b R-b R-b R-b R-b R-b R-b R-b | A-b | R-b R-b R-b R-b R-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCHSET v2 0/8] block plugging improvements
Series improving plugging for fast devices, but some fixes in here too.
Patch 1 changes the logic for when we sort the plug list, switching it to only doing it if we have requests for multiple queues in the plug (and enough requests to warrant an actual sort).
2-6 add a ->commit_rqs() hook and implement it in drivers that use (or will use) bd->last to optimize IO submission. If a driver currently uses bd->last to know if it's needed to kick the hardware into action, there are cases where we flag bd->last == false, but then fail to submit any further IO due to other resource constraints. We probably get saved by the fact that this happens for the case where we have pending IO and that will eventually guarantee forward progress, but we really should kick IO into gear at that point.
7 improves plugging for blk-mq.
In terms of improvements, for virtualized nvme, I've seen a 2-x IOPS improvement with proper handling of bd->last with this series.
Changes since v1:
- Fold the plug case for blk-mq, do it if we have 1 hw queue, or if we have ->commit_rqs().
- Add disable/enable IRQ to ataflop
- Drop nvme ring index helper
- Rework when to sort patch
Signature · 1 line
Jens Axboe