Skip to content

RFC fix some segmentation faults and migration issues

Fei Li qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest5 patches 12 repliesIn review
  2. v1 RFC5 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Update the commit message for patch 1/5, and get one more Reviewed-by.
- Get one Reviewed-by for patch 3/5.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Fix segmentation fault when qemu_signal_init failsutil/main-loop.c+4 -42 replies
2/5qemu_thread_join: fix segmentation faultutil/qemu-thread-posix.c util/qemu-thread-win32.c+4 -10 replies
3/5migration: fix the multifd code when receiving less channelsmigration/channel.c migration/migration.c migration/migration.h +2 more+21 -103 replies
4/5migration: remove unused &local_err parameter in multifd_save_cleanupmigration/migration.c migration/ram.c migration/ram.h+6 -123 replies
5/5migration: add more error handling for postcopy_ram_enable_notifymigration/postcopy-ram.c migration/savevm.c+2 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchFam ZhengMarkus ArmbrusterJuan QuintelaPeter XuDr. David Alan Gilbert
1/5R-b R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH RFC v2 0/5] fix some segmentation faults and migration issues

These five patches almost get the Reviewed-by and are extracted from previous "[PATCH RFC v7 0/9] qemu_thread_create: propagate errors to callers to check." The mentioned patch series have waited on one multifd issue for a while and still needs a further discussion.

Thus separate(send) these five almost-done patches and hope they can be merged for the next tag. Thanks for the review. :)

v2:
- Update the commit message for patch 1/5, and get one more Reviewed-by.
- Get one Reviewed-by for patch 3/5.

Fei Li (5):
Fix segmentation fault when qemu_signal_init fails
qemu_thread_join: fix segmentation fault
migration: fix the multifd code when receiving less channels
migration: remove unused &local_err parameter in multifd_save_cleanup
migration: add more error handling for postcopy_ram_enable_notify

 migration/channel.c      | 11 ++++++-----
 migration/migration.c    | 14 ++++++++------
 migration/migration.h    |  2 +-
 migration/postcopy-ram.c |  1 +
 migration/ram.c          | 18 ++++++++++--------
 migration/ram.h          |  4 ++--
 migration/savevm.c       |  1 +
 util/main-loop.c         |  8 ++++----
 util/qemu-thread-posix.c |  3 +++
 util/qemu-thread-win32.c |  2 +-
 10 files changed, 37 insertions(+), 27 deletions(-)
Signature · 1 line
2.13.7