Skip to content

arm64: Support HP Envy X2

Alexander Graf grub-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 5 repliesIn review
  2. v53 patches 7 repliesSuperseded
  3. v42 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches8 repliesSuperseded
v22 patches5 repliesSuperseded
v12 patches4 repliesSuperseded

Changes in v6 from the cover letter

- Change EFIxxHEADER_SIZE macros too
- Fix comment

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mkimage: Use EFI32_HEADER_SIZE define in arm-efi caseutil/mkimage.c+1 -60 replies
2/3mkimage: Align efi sections on 4k boundaryinclude/grub/efi/pe32.h+9 -20 replies
3/3mkimage: Clarify file alignment in efi caseutil/mkimage.c+6 -60 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel Kiper
SeriesR-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] arm64: Support HP Envy X2

I got a new toy recently: An HP Envy X2 system. This is one of those shiny new Qualcomm Snapdragon based Windows tablet/notebook hybrid things.

While running Windows on those is actually not a terribly bad experience now that WSL is out, I would like to see Linux run on those as well in the future.

Unfortunately as far as I'm aware so far nobody was able to run self built binaries on the built-in UEFI version.

Turns out, it's a problem with aligning the start of the header to 4k. Once we do that, binaries can be loaded just fine and run.

The reason behind that is simple: Its firmware tries to ensure NX protection flags and can do so only when the code is 4K aligned.

So to maintain compatibility with that device, this patch set just bumps all PE alignments to 4K always on all efi targets. This way we improve overall compatibility - there surely will be more devices coming with similar constraints.

This gets us into alignment with how the MS tools build UEFI applications, so we should not run into compatibility problems about alignment going forward.

v1 -> v2:

- Remove explicit device wording from patch
- Use GRUB_EFI_PAGE_SIZE

v2 -> v3:

- Apply alignment to all architectures
- new patch: mkimage: Align efi sections on 4k boundary

v3 -> v4:

- Reduce everything down to 1 patch which just adapts *all* alignment

    to GRUB_EFI_PAGE_SIZE (4k).

v4 -> v5:

- Use GRUB_EFI_PAGE_SIZE
- Add include to have above const defined
- new patch: mkimage: Clarify file alignment in efi case

v5 -> v6:

- Change EFIxxHEADER_SIZE macros too
- Fix comment

Alexander Graf (3):
mkimage: Use EFI32_HEADER_SIZE define in arm-efi case
mkimage: Align efi sections on 4k boundary
mkimage: Clarify file alignment in efi case

 include/grub/efi/pe32.h | 11 +++++++++--
 util/mkimage.c          | 19 +++++++------------
 2 files changed, 16 insertions(+), 14 deletions(-)
Signature · 1 line
2.12.3