Skip to content

Remove SRQ code from mlx5_core

Leon Romanovsky linux-rdma netdev 1 version Applied

Status from this message: Applied to mlx5-next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/11net/mlx5: Align SRQ licenses and copyright informationdrivers/infiniband/hw/mlx5/srq.c drivers/net/ethernet/mellanox/mlx5/core/srq.c include/linux/mlx5/srq.h+6 -870 replies
2/11net/mlx5: Remove dead transobj codedrivers/net/ethernet/mellanox/mlx5/core/transobj.c include/linux/mlx5/transobj.h+0 -710 replies
3/11net/mlx5: Remove not-used lib/eq.h header filedrivers/net/ethernet/mellanox/mlx5/core/srq.c+0 -10 replies
4/11net/mlx5: Remove references to local mlx5_core functionsdrivers/net/ethernet/mellanox/mlx5/core/srq.c+3 -190 replies
5/11net/mlx5: Move SRQ functions to RDMA partdrivers/infiniband/hw/mlx5/Makefile drivers/infiniband/hw/mlx5/cq.c drivers/infiniband/hw/mlx5/srq.c +7 more+49 -7980 replies
6/11RDMA/mlx5: Remove SRQ signature global flagdrivers/infiniband/hw/mlx5/srq.c+1 -40 replies
7/11RDMA/mlx5: Use stages for callback to setup and release DEVXdrivers/infiniband/hw/mlx5/main.c drivers/infiniband/hw/mlx5/mlx5_ib.h+20 -70 replies
8/11RDMA/mlx5: Update SRQ functions signatures to mlx5_ib formatdrivers/infiniband/hw/mlx5/cq.c drivers/infiniband/hw/mlx5/srq.c drivers/infiniband/hw/mlx5/srq.h +1 more+83 -770 replies
9/11RDMA/mlx5: Initialize SRQ tables on mlx5_ibdrivers/infiniband/hw/mlx5/ib_rep.c drivers/infiniband/hw/mlx5/main.c drivers/infiniband/hw/mlx5/mlx5_ib.h +8 more+101 -1220 replies
10/11RDMA/mlx5: Unfold create RMP functiondrivers/infiniband/hw/mlx5/srq_cmd.c+16 -190 replies
11/11RDMA/mlx5: Unfold modify RMP functiondrivers/infiniband/hw/mlx5/srq_cmd.c+34 -280 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchMark Bloch
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH mlx5-next 00/11] Remove SRQ code from mlx5_core

From: Leon Romanovsky <[email protected]>

Hi Doug and Jason,

This series is intended to be applied on mlx5-next after Saeed's infrastructure changes series are accepted:
https://patchwork.kernel.org/project/linux-rdma/list/?series=47809

----------------------------------------------------------------------
The following patchset brings mlx5 SRQ functionality to the module which is actually using it - mlx5_ib. The original code being not used in mlx5_core/mlx5_en, but located there, caused to unneeded maintenance overhead.

By moving mlx5 SRQ code to mlx5_ib, we successfully reduced ~200 LOC codes and minimized exports and headers pollution.

The proposed patches are divided to three logical groups: move from netdev, fix IB part and cleanup.

Thanks

Leon Romanovsky (11):
net/mlx5: Align SRQ licenses and copyright information net/mlx5: Remove dead transobj code
net/mlx5: Remove not-used lib/eq.h header file net/mlx5: Remove references to local mlx5_core functions net/mlx5: Move SRQ functions to RDMA part RDMA/mlx5: Remove SRQ signature global flag RDMA/mlx5: Use stages for callback to setup and release DEVX RDMA/mlx5: Update SRQ functions signatures to mlx5_ib format RDMA/mlx5: Initialize SRQ tables on mlx5_ib RDMA/mlx5: Unfold create RMP function
RDMA/mlx5: Unfold modify RMP function

 drivers/infiniband/hw/mlx5/Makefile           |   4 +-
 drivers/infiniband/hw/mlx5/cq.c               |   4 +-
 drivers/infiniband/hw/mlx5/ib_rep.c           |   4 +
 drivers/infiniband/hw/mlx5/main.c             |  33 +-
 drivers/infiniband/hw/mlx5/mlx5_ib.h          |   6 +-
 drivers/infiniband/hw/mlx5/srq.c              |  49 +--
 drivers/infiniband/hw/mlx5/srq.h              |  73 ++++
 .../srq.c => infiniband/hw/mlx5/srq_cmd.c}    | 321 ++++++++----------
 .../net/ethernet/mellanox/mlx5/core/Makefile  |   2 +-
 .../net/ethernet/mellanox/mlx5/core/main.c    |   5 -
 .../ethernet/mellanox/mlx5/core/transobj.c    | 109 ------
 include/linux/mlx5/driver.h                   |  33 --
 include/linux/mlx5/srq.h                      |  72 ----
 include/linux/mlx5/transobj.h                 |  11 -
 14 files changed, 274 insertions(+), 452 deletions(-)
 create mode 100644 drivers/infiniband/hw/mlx5/srq.h
 rename drivers/{net/ethernet/mellanox/mlx5/core/srq.c => infiniband/hw/mlx5/srq_cmd.c} (71%)
 delete mode 100644 include/linux/mlx5/srq.h