Skip to content

support flow dissector in BPF_PROG_TEST_RUN

Stanislav Fomichev netdev 4 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesApplied
  2. v2 posting 2/23 patches 7 repliesSuperseded
  3. v2 posting 1/25 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches5 repliesSuperseded

Changes in v3 from the cover letter

* rebased on top of latest bpf-next

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3net/flow_dissector: move bpf case into __skb_flow_bpf_dissectinclude/linux/skbuff.h net/core/flow_dissector.c+59 -380 replies
2/3bpf: add BPF_PROG_TEST_RUN support for flow dissectorinclude/linux/bpf.h net/bpf/test_run.c net/core/filter.c+86 -01 reply
3/3selftests/bpf: add simple BPF_PROG_TEST_RUN examples for flow dissectortools/testing/selftests/bpf/Makefile tools/testing/selftests/bpf/flow_dissector_load.c tools/testing/selftests/bpf/flow_dissector_load.h +1 more+139 -401 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSong Liu
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH bpf-next v3 0/3] support flow dissector in BPF_PROG_TEST_RUN

This patch series adds support for testing flow dissector BPF programs by extending already existing BPF_PROG_TEST_RUN. The goal is to have a packet as an input and `struct bpf_flow_key' as an output. That way we can easily test flow dissector programs' behavior.
I've also modified existing test_progs.c test to do a simple flow dissector run as well.

* first patch introduces new __skb_flow_bpf_dissect to simplify sharing between __skb_flow_bpf_dissect and BPF_PROG_TEST_RUN
* second patch adds actual BPF_PROG_TEST_RUN support
* third patch adds example usage to the selftests

v3:
* rebased on top of latest bpf-next

v2:
* loop over 'kattr->test.repeat' inside of
bpf_prog_test_run_flow_dissector, don't reuse
bpf_test_run/bpf_test_run_one

Stanislav Fomichev (3):
net/flow_dissector: move bpf case into __skb_flow_bpf_dissect
bpf: add BPF_PROG_TEST_RUN support for flow dissector selftests/bpf: add simple BPF_PROG_TEST_RUN examples for flow
dissector

 include/linux/bpf.h                           |  3 +
 include/linux/skbuff.h                        |  5 +
 net/bpf/test_run.c                            | 82 +++++++++++++++++
 net/core/filter.c                             |  1 +
 net/core/flow_dissector.c                     | 92 +++++++++++--------
 tools/testing/selftests/bpf/Makefile          |  3 +
 .../selftests/bpf/flow_dissector_load.c       | 43 +--------
 .../selftests/bpf/flow_dissector_load.h       | 55 +++++++++++
 tools/testing/selftests/bpf/test_progs.c      | 78 +++++++++++++++-
 9 files changed, 284 insertions(+), 78 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/flow_dissector_load.h
Signature · 1 line
2.20.1.495.gaa96b0ce6b-goog