Skip to content

Tegra210 DFLL support

Joseph Lo linux-arm-kernel linux-clk linux-devicetree linux-pm linux-tegra 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest20 patches 10 repliesIn review
  2. v320 patches 20 repliesSuperseded
  3. v221 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v119 patches53 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20dt-bindings: clock: tegra124-dfll: Update DFLL binding for PWM regulatorDocumentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt+77 -23 replies
2/20dt-bindings: clock: tegra124-dfll: add Tegra210 supportDocumentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt+3 -10 replies
3/20dt-bindings: cpufreq: tegra124: remove vdd-cpu-supply from required propertiesDocumentation/devicetree/bindings/cpufreq/nvidia,tegra124-cpufreq.txt+0 -20 replies
4/20dt-bindings: cpufreq: tegra124: remove cpu_lp clock from required propertiesDocumentation/devicetree/bindings/cpufreq/nvidia,tegra124-cpufreq.txt+1 -30 replies
5/20clk: tegra: dfll: registration for multiple SoCsdrivers/clk/tegra/clk-tegra124-dfll-fcpu.c+34 -110 replies
6/20clk: tegra: dfll: CVB calculation alignment with the regulatordrivers/clk/tegra/clk-dfll.h drivers/clk/tegra/clk-tegra124-dfll-fcpu.c drivers/clk/tegra/cvb.c +1 more+59 -140 replies
7/20clk: tegra: dfll: support PWM regulator controldrivers/clk/tegra/clk-dfll.c+377 -670 replies
8/20clk: tegra: dfll: round down voltages based on alignmentdrivers/clk/tegra/clk-dfll.c+13 -80 replies
9/20clk: tegra: dfll: add CVB tables for Tegra210drivers/clk/tegra/clk-tegra124-dfll-fcpu.c drivers/clk/tegra/cvb.h+427 -00 replies
10/20clk: tegra: dfll: build clk-dfll.c for Tegra124 and Tegra210drivers/clk/tegra/Kconfig drivers/clk/tegra/Makefile+6 -12 replies
11/20cpufreq: tegra124: do not handle the CPU raildrivers/cpufreq/Kconfig.arm drivers/cpufreq/tegra124-cpufreq.c+4 -410 replies
12/20cpufreq: tegra124: extend to support Tegra210drivers/cpufreq/tegra124-cpufreq.c+2 -10 replies
13/20cpufreq: dt-platdev: add Tegra210 to blacklistdrivers/cpufreq/cpufreq-dt-platdev.c+1 -00 replies
14/20arm64: dts: tegra210: add DFLL clockarch/arm64/boot/dts/nvidia/tegra210.dtsi+19 -00 replies
15/20arm64: dts: tegra210: add CPU clocksarch/arm64/boot/dts/nvidia/tegra210.dtsi+6 -00 replies
16/20arm64: dts: tegra210-p2597: add pinmux for PWM-based DFLL supportarch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi+14 -00 replies
17/20arm64: dts: tegra210-p2371-2180: enable DFLL clockarch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts+21 -00 replies
18/20arm64: dts: tegra210-smaug: add CPU power rail regulatorarch/arm64/boot/dts/nvidia/tegra210-smaug.dts+19 -00 replies
19/20arm64: dts: tegra210-smaug: enable DFLL clockarch/arm64/boot/dts/nvidia/tegra210-smaug.dts+12 -00 replies
20/20arm64: defconfig: Enable MAX8973 regulatorarch/arm64/configs/defconfig+1 -00 replies

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchJon HunterStephen BoydRob HerringViresh Kumar
1/20A-b R-b
2/20A-b A-b R-b
3/20A-b R-b
4/20A-b R-b
5/20A-b A-b
6/20A-b A-b
7/20A-b A-b
8/20A-b A-b
9/20A-b A-b
10/20A-b A-b
11/20A-b A-b
12/20A-b A-b
13/20A-b A-b
14/20A-b
15/20A-b
16/20A-b
17/20A-b
18/20A-b
19/20A-b
20/20A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH V4 00/20] Tegra210 DFLL support

This series introduces support for the DFLL as a CPU clock source on Tegra210. As Jetson TX1 uses a PWM controlled regulator IC which is driven directly by the DFLLs PWM output, we also introduce support for PWM regulators next to I2C controlled regulators. The DFLL output frequency is directly controlled by the regulator voltage. The registers for controlling the PWM are part of the DFLL IP block, so there's no separate linux regulator object involved because the regulator IC only supplies the rail powering the CPUs. It doesn't have any other controls.

The patch 1~4 are the patches of DT bindings update for DFLL clock and Tegra124 cpufreq, which add PWM and Tegra210 support for DFLL clock and remove deprecate properties for Tegra124 cpufreq bindings.

The patch 5~10 are the patches for DFLL clock driver update for PWM-mode DFLL support.

The patch 11~13 are the Tegra124 cpufreq driver update to make it work with Tegra210.

The patch 14~19 are the devicetree files update for Tegra210 SoC and platforms. Two platforms are updated here for different DFLL mode usage. The Tegra210-p2371-2180 (a.k.a. Jetson Tx1) uses DFLL-PWM and the Tegra210-smaug (a.k.a. Pixel C) uses DFLL-I2C. So two different modes are verified with this series.

The patch 20 is the patch for enabling the CPU regulator for Smaug board.

* Update in V4:
- s/nvidia,pwm-period/nvidia,pwm-period-nanoseconds/ in patch 1 for DFLL DT bindings update.
- remove parenthesis in Kconfig of DFLL driver
- add more ack and RB tags

* Update in V3:
- Squash patch 9 in previous series into patch 7 (ref. [0])
- minor fixes in patch 6 for geting alignment data
- more variable type fixes in patch 7
- fix the error handling in patch 8
- collect more ack tags

* Update in V2:
- Add two patches that suggested from comments in V1. See patch 9 and 14.
- Update DT binding for DFLL-PWM mode in patch 1.
- Update the code for how to get regulator data from DT or regulator API in patch 6.
- Update to use lut_uv table for LUT lookup in patch 7. That makes the generic lut table to work with both I2C and PWM mode.
- not allow Tegra124 cpufreq driver to be built as a module and remove the removal function in patch 12.

[0]: http://patchwork.ozlabs.org/project/linux-tegra/list/?series=81595

Joseph Lo (17):
dt-bindings: clock: tegra124-dfll: add Tegra210 support
dt-bindings: cpufreq: tegra124: remove vdd-cpu-supply from required
properties
dt-bindings: cpufreq: tegra124: remove cpu_lp clock from required
properties
clk: tegra: dfll: CVB calculation alignment with the regulator
clk: tegra: dfll: support PWM regulator control
clk: tegra: dfll: round down voltages based on alignment
clk: tegra: dfll: add CVB tables for Tegra210
cpufreq: tegra124: do not handle the CPU rail
cpufreq: tegra124: extend to support Tegra210
cpufreq: dt-platdev: add Tegra210 to blacklist
arm64: dts: tegra210: add DFLL clock
arm64: dts: tegra210: add CPU clocks
arm64: dts: tegra210-p2597: add pinmux for PWM-based DFLL support
arm64: dts: tegra210-p2371-2180: enable DFLL clock
arm64: dts: tegra210-smaug: add CPU power rail regulator
arm64: dts: tegra210-smaug: enable DFLL clock
arm64: defconfig: Enable MAX8973 regulator

Peter De Schrijver (3):
dt-bindings: clock: tegra124-dfll: Update DFLL binding for PWM
regulator
clk: tegra: dfll: registration for multiple SoCs
clk: tegra: dfll: build clk-dfll.c for Tegra124 and Tegra210

 .../bindings/clock/nvidia,tegra124-dfll.txt   |  83 ++-
 .../cpufreq/nvidia,tegra124-cpufreq.txt       |   6 +-
 .../boot/dts/nvidia/tegra210-p2371-2180.dts   |  21 +
 .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi |  14 +
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts |  31 ++
 arch/arm64/boot/dts/nvidia/tegra210.dtsi      |  25 +
 arch/arm64/configs/defconfig                  |   1 +
 drivers/clk/tegra/Kconfig                     |   5 +
 drivers/clk/tegra/Makefile                    |   2 +-
 drivers/clk/tegra/clk-dfll.c                  | 459 +++++++++++++---
 drivers/clk/tegra/clk-dfll.h                  |   6 +-
 drivers/clk/tegra/clk-tegra124-dfll-fcpu.c    | 520 +++++++++++++++++-
 drivers/clk/tegra/cvb.c                       |  12 +-
 drivers/clk/tegra/cvb.h                       |   7 +-
 drivers/cpufreq/Kconfig.arm                   |   4 +-
 drivers/cpufreq/cpufreq-dt-platdev.c          |   1 +
 drivers/cpufreq/tegra124-cpufreq.c            |  44 +-
 17 files changed, 1093 insertions(+), 148 deletions(-)
Signature · 1 line
2.20.1