Skip to content

crypto threads

Vladimir Sementsov-Ogievskiy qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 10 repliesIn review
  2. v25 patches 13 repliesSuperseded
  3. v15 patches 1 replySuperseded

Changes in v3 from the cover letter

01: add r-b by Daniel and Alberto
02: Alberto r-b

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5crypto/block-luks: fix memory leak in qcrypto_block_luks_createcrypto/block-luks.c+3 -00 replies
2/5crypto/block: refactor qcrypto_block_*crypt_helper functionscrypto/block.c+31 -500 replies
3/5crypto/block: rename qcrypto_block_*crypt_helpercrypto/block-luks.c crypto/block-qcow.c crypto/block.c +1 more+83 -813 replies
4/5crypto/block: introduce qcrypto_block_*crypt_helper functionscrypto/block-luks.c crypto/block-qcow.c crypto/block.c +1 more+54 -161 reply
5/5crypto: support multiple threads accessing one QCryptoBlockblock/crypto.c block/qcow.c block/qcow2.c +6 more+172 -445 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchDaniel P. BerrangéAlberto Garcia
1/5R-b R-b
2/5R-b
3/5R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/5] crypto threads

Hi all.

v3:
01: add r-b by Daniel and Alberto
02: Alberto r-b

    encrypt->encdec for generic

03: qcrypto_cipher_*crypt_helper->
qcrypto_block_cipher_*crypt_helper
04: rebased on previous renamings
Daniel r-b
05: use size_t
improve comment about n_threads
don't use ret in qcrypto_block_luks_create
do qemu_mutex_init at the end of open/create
do qemu_mutex_destroy in free
fix comment for qcrypto_block_get_cipher

v2:
05: fix compilation of test-crypto-block (I am ashamed:(
and change QCryptoBlock interface to be a bit more safe.

These series are preliminary step before moving encryption code in qcow2 to the threads. The first attempt of doing it is on list ([PATCH 00/11] qcow2: encryption threads :
https://lists.gnu.org/archive/html/qemu-block/2018-11/msg00729.html)
But it's approach with multiplying the whole QCryptoBlock per thread was rejected. So, here is a solution to maintain multitasking inside QCryptoBlock.

Vladimir Sementsov-Ogievskiy (5):
crypto/block-luks: fix memory leak in qcrypto_block_luks_create crypto/block: refactor qcrypto_block_*crypt_helper functions crypto/block: rename qcrypto_block_*crypt_helper crypto/block: introduce qcrypto_block_*crypt_helper functions
crypto: support multiple threads accessing one QCryptoBlock

 crypto/blockpriv.h        |  42 +++++--
 include/crypto/block.h    |   2 +
 block/crypto.c            |   1 +
 block/qcow.c              |   2 +-
 block/qcow2.c             |   4 +-
 crypto/block-luks.c       |  57 +++++-----
 crypto/block-qcow.c       |  26 ++---
 crypto/block.c            | 225 +++++++++++++++++++++++++++++---------
 tests/test-crypto-block.c |   3 +
 9 files changed, 257 insertions(+), 105 deletions(-)
Signature · 1 line
2.18.0