Skip to content

Consolidate iommu_ops->add/remove_device() calls

Joerg Roedel linux-iommu lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 7 repliesIn review
  2. v14 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4iommu/sysfs: Rename iommu_release_device()drivers/iommu/iommu-sysfs.c+6 -60 replies
2/4iommu: Consolitate ->add/remove_device() callsdrivers/iommu/iommu.c include/linux/iommu.h+28 -260 replies
3/4iommu/of: Don't call iommu_ops->add_device directlydrivers/iommu/of_iommu.c+3 -36 replies
4/4ACPI/IORT: Don't call iommu_ops->add_device directlydrivers/acpi/arm64/iort.c+2 -21 reply

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchHanjun Guo
1/4
2/4
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/4 v2] Consolidate iommu_ops->add/remove_device() calls

Hi,

here is the second version of the patch-set to wrap the invocation of iommu_ops->add/remove_device() into functions. The functions will do more setup stuff later when the the iommu-related pointers in 'struct device' are consolidated.

Since version one this patch-set was rebased to v4.20-rc6 and I removed the pointer checks for the function pointers, as suggested by Robin. I checked all 16 drivers and all of them implement the add/remove_device call-backs.

Please review, if there are no objections I plan to queue these patches in the IOMMU tree.

Thanks,

Joerg

Joerg Roedel (4):
iommu/sysfs: Rename iommu_release_device()
iommu: Consolitate ->add/remove_device() calls iommu/of: Don't call iommu_ops->add_device directly ACPI/IORT: Don't call iommu_ops->add_device directly

 drivers/acpi/arm64/iort.c   |  4 +--
 drivers/iommu/iommu-sysfs.c | 12 ++++-----
 drivers/iommu/iommu.c       | 51 ++++++++++++++++++-------------------
 drivers/iommu/of_iommu.c    |  6 ++---
 include/linux/iommu.h       |  3 +++
 5 files changed, 39 insertions(+), 37 deletions(-)
Signature · 1 line
2.17.1

Read the cover letter in its thread