Skip to content

neighbor: cleanups plus extack for add and delete

David Ahern netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7neighbor: Remove open coding of key and hash functionsinclude/net/arp.h include/net/ndisc.h net/core/filter.c+3 -40 replies
2/7neighbor: Fold ___neigh_lookup_noref into __neigh_lookup_norefinclude/net/neighbour.h+5 -174 replies
3/7net/ipv4: Move arp_hashfn into arp_hashinclude/net/arp.h net/ipv4/arp.c+4 -90 replies
4/7net/ipv6: Move ndisc_hashfn to ndisc_hashinclude/net/ndisc.h net/ipv6/ndisc.c+6 -110 replies
5/7neighbor: Create a neigh_hash helperinclude/net/neighbour.h net/core/neighbour.c+14 -110 replies
6/7neighbor: Skip the duplicate lookup in neigh_addnet/core/neighbour.c+1 -10 replies
7/7neighbor: Add extack messages for add and delete commandsnet/core/neighbour.c+39 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/7] neighbor: cleanups plus extack for add and delete

From: David Ahern <[email protected]>

cleanups:
- remove open coding of key and hash functions for ipv4 and ipv6 and then collapse hash functions
- collapse now unnecessary ___neigh_lookup_noref helper
- create helper for neigh hash computation
- remove duplicate lookup in neigh_add

After that add extack messages for neighbor add and delete.

David Ahern (7):
neighbor: Remove open coding of key and hash functions
neighbor: Fold ___neigh_lookup_noref into __neigh_lookup_noref net/ipv4: Move arp_hashfn into arp_hash
net/ipv6: Move ndisc_hashfn to ndisc_hash
neighbor: Create a neigh_hash helper
neighbor: Skip the duplicate lookup in neigh_add
neighbor: Add extack messages for add and delete commands

 include/net/arp.h       | 10 +------
 include/net/ndisc.h     | 12 +--------
 include/net/neighbour.h | 30 +++++++++------------
 net/core/filter.c       |  3 +--
 net/core/neighbour.c    | 72 ++++++++++++++++++++++++++++++-------------------
 net/ipv4/arp.c          |  5 +++-
 net/ipv6/ndisc.c        |  7 ++++-
 7 files changed, 71 insertions(+), 68 deletions(-)
Signature · 1 line
2.11.0