vmdk: Implement blockdev-create
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 12 repliesIn review
- v34 patches 6 repliesSuperseded
Changes in v4 from the cover letter
- Use "legacyESX" in QAPI instead of "legacyesx" (requires an additional exception from the QAPI rules, but the string is directly written into the VMDK file, and "legacyESX" is the spelling in the spec). The QemuOpts based parser stays case sensitive in v4. [Markus]
- Documentation fixes [Markus]
- Added tests for adapter types
- Added patch 5 to forbid excess extents in blockdev-create [Markus]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | vmdk: Refactor vmdk_create_extentblock/ | +43 | 0 replies | |
| 2/5 | vmdk: Implement .bdrv_co_create callbackblock/ qapi/ qapi/ | +400 | 2 replies | |
| 3/5 | iotests: Filter cid numbers in VMDK extent infotests/ tests/ | +2 | 0 replies | |
| 4/5 | iotests: Add VMDK tests for blockdev-createtests/ tests/ tests/ | +581 | 7 replies | |
| 5/5 | vmdk: Reject excess extents in blockdev-createblock/ qapi/ tests/ +1 more | +38 | 3 replies |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Markus Armbruster |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | |
| 4/5 | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 0/5] vmdk: Implement blockdev-create
I picked up the patch series from Fam and rebased it to current master (which involved a major rework on the test case) and tried to address Markus' review comments for v2. I did not do any further review of the actual code, but it passes the tests, so I guess having it in tree is better than continuing to let it bitrot.
v4:
- Use "legacyESX" in QAPI instead of "legacyesx" (requires an additional exception from the QAPI rules, but the string is directly written into the VMDK file, and "legacyESX" is the spelling in the spec). The QemuOpts based parser stays case sensitive in v4. [Markus]
- Documentation fixes [Markus]
- Added tests for adapter types
- Added patch 5 to forbid excess extents in blockdev-create [Markus]
Fam Zheng (3):
vmdk: Refactor vmdk_create_extent
vmdk: Implement .bdrv_co_create callback
iotests: Filter cid numbers in VMDK extent info
Kevin Wolf (2):
iotests: Add VMDK tests for blockdev-create
vmdk: Reject excess extents in blockdev-create
qapi/block-core.json | 71 +++++ qapi/qapi-schema.json | 16 +- block/vmdk.c | 532 ++++++++++++++++++++++--------- tests/qemu-iotests/237 | 237 ++++++++++++++ tests/qemu-iotests/237.out | 348 ++++++++++++++++++++ tests/qemu-iotests/common.filter | 1 + tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 1 + 8 files changed, 1049 insertions(+), 158 deletions(-) create mode 100755 tests/qemu-iotests/237 create mode 100644 tests/qemu-iotests/237.out
Signature · 1 line
2.19.2