Skip to content

bitmaps: remove x- prefix from QMP api

John Snow qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 8 repliesIn review
  2. v511 patches 19 repliesSuperseded
  3. v45 patches 18 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches11 repliesSuperseded
v27 patches15 repliesSuperseded
v13 patches9 repliesSuperseded

Changes in v6 from the cover letter

- Cover letter touchups
- 09: Rewrite qmp_filter to cope with lists or dicts.
- 11: small touchups.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11blockdev: abort transactions in reverse orderblockdev.c+7 -72 replies
2/11block/dirty-bitmap: remove assertion from restoreblock/dirty-bitmap.c+0 -10 replies
3/11blockdev: n-ary bitmap mergeblockdev.c qapi/block-core.json+62 -350 replies
4/11block: remove 'x' prefix from experimental bitmap APIsblockdev.c qapi/block-core.json qapi/transaction.json +1 more+36 -362 replies
5/11iotests.py: don't abort if IMGKEYSECRET is undefinedtests/qemu-iotests/iotests.py+1 -10 replies
6/11iotests: add filter_generated_node_idstests/qemu-iotests/iotests.py+3 -00 replies
7/11iotests: add qmp recursive sorting functiontests/qemu-iotests/iotests.py+20 -40 replies
8/11iotests: remove default filters from qmp_logtests/qemu-iotests/206 tests/qemu-iotests/iotests.py+7 -30 replies
9/11iotests: change qmp_log filters to expect QMP objects onlytests/qemu-iotests/206 tests/qemu-iotests/iotests.py+27 -53 replies
10/11iotests: implement pretty-print for log and qmp_logtests/qemu-iotests/iotests.py+10 -50 replies
11/11iotests: add iotest 236 for testing bitmap mergetests/qemu-iotests/236 tests/qemu-iotests/236.out tests/qemu-iotests/group+513 -01 reply

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchEric BlakeVladimir Sementsov-Ogievskiy
1/11R-b R-b
2/11R-b R-b
3/11R-b R-b
4/11R-b R-b
5/11R-b R-b
6/11R-b R-b
7/11R-b R-b
8/11R-b R-b
9/11R-b
10/11R-b R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 00/11] bitmaps: remove x- prefix from QMP api

Fix some outstanding bugs, change the design of an API element, remove the x- prefix to signify stability, and add iotests.

V6:
- Cover letter touchups
- 09: Rewrite qmp_filter to cope with lists or dicts.
- 11: small touchups.

V5:

002: New bugfix.
003: I forgot to actually capture state->bitmap anywhere,
which is needed for restoration...
007: Better commit message
- use .items() instead of .keys() to save a lookup [Vladimir]
- use a sequence of tuples to preserve ordering in the OrderedDict constructor [Vladimir]
- Move the sort_keys boolean up from patch 010
008: Better commit message
009: Better commit message
010: Moved the sort_keys function up to patch 007
011: Expanded this test considerably:
- query_bitmaps can now show empty results,
and prefixes results with "bitmaps:" in the log
- logging declarations are one line [Vladimir]
- Added a bad version of the bitmap handoff transaction [Eric]
- Added a bad version of the bitmap merge transaction, which revealed a problem that patch 02 now addresses [Eric]
- Added bitmap removal / cleanup [Eric]
- Added newline at end of file. [Eric]

V4:
- Removed patches 1-5 which have been staged
- Rewrite qmp_log entirely, split into three patches
- Pretty-printing has been extended to log() as well as qmp_log()
- Adjust iotest 236 to be format generic instead of qcow2 [Vladimir]
- Adjust iotest 236 to not reduplicate serialization work [Vladimir]
- Many other small touchups

V3:
- Reworked qmp_log to pretty-print the outgoing command, too [Vladimir]
- Modified test to log only bitmap information [Vladimir]
- Test disable/enable transaction toggle [Eric]

John Snow (11):
blockdev: abort transactions in reverse order block/dirty-bitmap: remove assertion from restore
blockdev: n-ary bitmap merge
block: remove 'x' prefix from experimental bitmap APIs iotests.py: don't abort if IMGKEYSECRET is undefined
iotests: add filter_generated_node_ids
iotests: add qmp recursive sorting function
iotests: remove default filters from qmp_log
iotests: change qmp_log filters to expect QMP objects only
iotests: implement pretty-print for log and qmp_log
iotests: add iotest 236 for testing bitmap merge

 block/dirty-bitmap.c          |   1 -
 blockdev.c                    | 107 +++++++----
 qapi/block-core.json          |  56 +++---
 qapi/transaction.json         |  12 +-
 tests/qemu-iotests/206        |   8 +-
 tests/qemu-iotests/223        |   4 +-
 tests/qemu-iotests/236        | 161 ++++++++++++++++
 tests/qemu-iotests/236.out    | 351 ++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/group      |   1 +
 tests/qemu-iotests/iotests.py |  64 ++++++-
 10 files changed, 677 insertions(+), 88 deletions(-)
 create mode 100755 tests/qemu-iotests/236
 create mode 100644 tests/qemu-iotests/236.out
Signature · 1 line
2.17.2