userfaultfd: check VM_MAYWRITE was set after verifying the uffd is registered
Status from this message: [merged] userfaultfd-check-vm_maywrite-was-set-after-verifying-the-uffd-is-registered.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 1 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | userfaultfd: check VM_MAYWRITE was set after verifying the uffd is registeredfs/ | +2 | 3 replies | Applied |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Mike Rapoport | Hugh Dickins | Peter Xu |
|---|---|---|---|
| 1/1 | A-b | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/1] userfaultfd: check VM_MAYWRITE was set after verifying the uffd is registered
Hello,
The juxtaposition with the other bugchecks didn't make it apparent that the this WARN_ON was one line too soon.
An app trying to unregister a not-yet-registered range will trigger an _harmless_ false positive WARN_ON. No real app would do that so it went unnoticed during testing.
This should be applied on top of 29ec90660d68 ("userfaultfd:
shmem/hugetlbfs: only allow to register VM_MAYWRITE vmas") to shut off the false positive warning.
Thanks,
Andrea
Andrea Arcangeli (1):
userfaultfd: check VM_MAYWRITE was set after verifying the uffd is
registered
fs/userfaultfd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)